I guess I'll clarify... The Wack0 leaks included entire lotchecks for the Famicom, Game Boy, and Famicom Disk System. In other words, Nintendo keeps entire archives for most if not all of their systems.
For cart based games, the rom data won't change across the same revision so it's relatively easy to get a clean dump like you would if you got the game brand new. Floppy disks are a completely different story. These disks were designed to be written on to save progress. The games after being dumped, would have to be hacked to remove this save data. You can read about this here...http://archive.nes.science/nesdev-forums/f10/t12911.xhtml
For normal users, this works. But for posterity, it's an approximation of how the original disk image was before being written to.
As a result, any FDS disk image not dumped from a sealed copy was automatically identified as a bad dump on no-intro. Some people who were datting for no-intro would buy Famicom Disk System games sealed. As you could imagine, tracking these sealed copies down was tedious and costly.
And then came the wack0 leaks... The entire FDS's library was leaked online. Not only that, these were dumped from master disks. They were the original disk images before being modified with save data. This is the holy grail for datters, to say the least.
A lot of translations and hacks for the FDS here, and I don't think any of them are compatible with the leaked master set FDS batch.
Now to answer this question... I don't see the dump you choose posing difficulties during patching in this case. You will only encounter patching issues if the disk image you're patching differs significantly from the disk image used to generate the patch. I'm talking about file size differences (which shifts around data) and differences in data that are being modified by the patch. When comparing lotcheck disk images with trustworthy dumps with savedata hacks, we're talking about minute differences in metadata and save data. Most hacks won't be touching this.
Old FDS translations offer a utility to expand the disk image's files and an IPS patch. IPS patches don't care about the checksum of the disk image. For newer translations, they may offer a patch in the form of BPS or XDelta which do care about checksums. They would throw an error claiming a checksum mismatch. The most straightforward solution I can provide is to use this patcher...https://www.romhacking.net/patch/
When a checksum mistmatch occurs, it gives a warning which can be overridden. Also, when in doubt about a patch being incompatible with a disk image / rom file, try patching it. You may be pleasantly surprised.
June 13, 2021, 10:46:36 am - (Auto Merged - Double Posts are not allowed before 7 days.)
I'm going to follow up on my post as there appears to be a miconception about No-intro and its relation to the Wack0 leaks:
The hashes are different from any other set, including every known no-intro. Why would a patch for another ROM work with them?
The No-Intro specs are fine as to my understanding they come from community members dumping their own disks. I suspect writing patches to fit Gigaleak images falls in the same sort of gray area as writing hacks based on Gigaleak source code and emulators based on Gigaleak resources. No one does it because it's based on illegally obtained data from Nintendo and is vulnerable to legal action. No-Intro is clean and widely available.
No-intro's Dat-o-matic contains dats. These are information about roms. While before the leaks, all dats were based on community made dumps and modifications, after the leaks, this is not true for FDS image dumps. For previously stated reasons, the Nintendo FDS lotcheck was the holy grail. As a result, some FDS no-intro dats reference the Nintendo lotchecks. For example, this dump of "Idol Hotline - Nakayama Miho no Tokimeki High School (Japan) (DV 13) (Disk Writer)" references the dump origin of "Nintendo Master Archive" and dumper "Nintendo Leak"...https://datomatic.no-intro.org/index.php?page=show_record&s=31&n=0401
As for legal concerns, there shouldn't be any. Like I said before, no-intro's dat-o-matic contains dats, and doesn't host any roms or disk images.