Author Topic: Chrono Trigger Bugfix and Uncensoring Patch (Read 193743 times)

Cthulhu88 · « **Reply #440 on:** August 04, 2021, 07:01:26 pm »

Are these two supposed to be "Magus"? Hard to say since it's Frog saying them but before Magus is revealed.

Quote from: AuronSerge0123 on July 28, 2021, 01:50:06 pm

So I wasn't sure if this is the appropriate place to post this, but I found that Time Rock Orchestra would like to contribute his remastered track for Chrono Trigger; I saw him post in the Chrono Compendium forums. Here is his YouTube profile (https://www.youtube.com/channel/UCJVAwIJZabtM8y-XiOZ-Dtg), take a look at his Chrono Trigger playlist; all his tracks are great.

Anyone can create tracks for any of the ROMs supporting MSU-1.
Download MSUPCM++ at https://github.com/qwertymodo/msupcmplusplus/releases/ and then create a json config for converting your tracks to the MSU-1 PCM format, which is just a headerless 44100hz stereo PCM WAVE. One can use the chrono_symphony.json as an example.
MSU-1 PCM format is:
ID (4 bytes): Always 8-bits ASCII "MSU1"
LOOP POINT (4 bytes): Start of the loop, in samples.
DATA (4 bytes per stereo sample): PCM WAVE data (16-bits left sample, 16-bits right sample)

Chronosplit · « **Reply #441 on:** August 05, 2021, 07:26:02 pm »

When Frog says it, the word must be Magus. I feel like it's more consistent for all party members to just call him by the character name still, because Frog would either need to be calling him Fiendlord through the whole game or at some point just suddenly start calling him Magus (I wouldn't really be writing in new material to the script, so there wouldn't be a point where Frog finds out from the party or whatever).

I internally explain this away with the fact that history has him around Ozzie and Slash where he might have learned it, and I do have the fiends still using Magus's name.

Cthulhu88 · « **Reply #442 on:** August 06, 2021, 01:47:56 am »

Quote from: Chronosplit on August 05, 2021, 07:26:02 pm

When Frog says it, the word must be Magus. I feel like it's more consistent for all party members to just call him by the character name still, because Frog would either need to be calling him Fiendlord through the whole game or at some point just suddenly start calling him Magus (I wouldn't really be writing in new material to the script, so there wouldn't be a point where Frog finds out from the party or whatever).

I internally explain this away with the fact that history has him around Ozzie and Slash where he might have learned it, and I do have the fiends still using Magus's name.

I just saw a video on the DS version and that translation uses Fiendlord for this specific dialogue.

One explanation you could come with is that despite him knowing Magus' name, he uses Fiendlord because the party doesn't know who Magus is yet, which honestly makes sense if you are playing the game for the first time; only some minor mentions of Magus (Medina and statue) up to that point.

Chronosplit · « **Reply #443 on:** August 06, 2021, 08:29:02 am »

Quote from: Cthulhu88 on August 06, 2021, 01:47:56 am

I just saw a video on the DS version and that translation uses Fiendlord for this specific dialogue.
Quote
Hmm. I'll have to look this up and see how it's handled. My DS script source was partial when making this, so I admit that I'm probably missing a better handling of this situation.

Quote
One explanation you could come with is that despite him knowing Magus' name, he uses Fiendlord because the party doesn't know who Magus is yet, which honestly makes sense if you are playing the game for the first time; only some minor mentions of Magus (Medina and statue) up to that point.
Sort of. I'm a bit clever with the Heckran. Because that battle uses both names, the party knows what's up there. But I could change this back around too, I need to see how the DS version handles the Heckran's defeat as well.

Cthulhu88 · « **Reply #444 on:** August 06, 2021, 05:36:53 pm »

Quote from: Chronosplit on August 06, 2021, 08:29:02 am

Sort of. I'm a bit clever with the Heckran. Because that battle uses both names, the party knows what's up there. But I could change this back around too, I need to see how the DS version handles the Heckran's defeat as well.

Some NPCs in Medina refer to Magus and Lavos in the same sentence/area too.

Ugh... Nintendo of America and its censorship. It was so much easier for the original creators because his original name meant both things.
Hey... Let's censor everything religion related but name three plot characters after mythological christian characters. I am surprised they didn't censor the cathedral after censoring "Ten".

I am not a fan of Woolsey's "translation" myself; unfortunately the DS version, despite what people say, is NOT the definitive version for this game. The graphics look like garbage, the extra areas are awful and the extra items are overpowered to the point of breaking huge sections of the game (see Spekkio lv99).

Cthulhu88 · « **Reply #445 on:** August 13, 2021, 09:30:07 pm »

I wasn't happy with the current fix from 1.1.3, so I decided to refactor it.
I also checked and that problem fixed by 1.1.3, also occurs in both qwertymodo and DarkShock patches.

The issue with the fix from 1.1.3 is that while it fixes replaying tracks under certain conditions, it can also theoretically cancel out resuming a track from a certain sample offset.
Take this example:

A track is currently playing.
Game requests to interrupt this track to play another.
MSU-1 code saves the current sample offset of the current track and starts playing the new track.
New track finishes playing and the previous track is resumed.
Now, we haven't really started replaying the previous track because either the SPC isn't muted yet or because the current volume is below the threshold; we have just loaded it into MSU-1.
Game repeats a request for playing this track, forcing a reload of the track which causes the resume sample offset to be lost, making the track plays from the beginning.

To fix this, I've added a new bitflag that is reset when the track has just been loaded into MSU-1 and set when it actually starts playing. We check for this flag when the requested track is the loaded track.
Now we only replay a track under this condition when the loaded track had previously started playing and when it's currently not playing.

Code: [Select]

        cpx.b Track.CURRENT
        bne +
        lda.b #Flags.MSU_AUDIO_STARTED
        bit.b FLAGS
        beq .Exit
        MSU.not_playing(Mode.ABS, .Exit)

Other than that, I went through another pass of the code to improve whatever was left to improve.
Not much was left to improve because I've had this done multiple times back in 2019, but the minor stuff I could find was also improved.

I also did a cycle comparison between my hack and qwertymodo's when executing the default (nop) code at NMI, which is executed once every frame at VBLANK and needs to be the most optimized.
Mine is the same for versions 1.1.2 (2019), 1.1.3 and 1.1.4.

Hack	CPU cycles	Master Clock cycles
Mine	52	336
qwertymodo	93	610
qwertymodo (NO MSU-1)	32	208

As you can see my hack performs 45% faster than qwertymodo's and 38% slower than qwertymodo's without MSU-1.
Since no extra code is ever executed when there is no MSU-1, the comparison against his NO MSU-1 is moot.

The complete instruction-by-instruction cycle table:

Mine 1.1.2(2019), 1.1.3, 1.1.4:

Spoiler:

Code: [Select]

php                     // 3   -> 20
rep #$20                // 3   -> 18
pha                     // 4   -> 28
phd                     // 4   -> 28
lda.w #Memory.PAGE      // 3   -> 18
tcd                     // 2   -> 12
sep #$20                // 3   -> 18
lda.b Track.VOLUME      // 3   -> 20
cmp.b Track.FADE_VOLUME // 3   -> 20
beq .Default            // 3   -> 18
.Default:               //
rep #$20                // 3   -> 18
pld                     // 5   -> 34
pla                     // 5   -> 34
plp                     // 4   -> 26
jml $000500             // 4   -> 24
TOTAL:                  // 52  -> 336

qwertymodo:

Spoiler:

Code: [Select]

php                     // 3   -> 20
rep #$30                // 3   -> 18
pha                     // 4   -> 28
lda.l msuFound          // 6   -> 40
beq call_nmi_fast       // 2   -> 12
phb                     // 3   -> 20
phd                     // 4   -> 28
phx                     // 4   -> 28
phy                     // 4   -> 28
sep #$20                // 3   -> 18
lda.b #$00              // 2   -> 12
pha                     // 3   -> 20
plb                     // 4   -> 26
lda.l currentVolume     // 5   -> 32
cmp.l targetVolume      // 5   -> 32
beq call_nmi            // 3   -> 18
call_nmi:               //
rep #$30                // 3   -> 18
ply                     // 5   -> 34
plx                     // 5   -> 34
pld                     // 5   -> 34
plb                     // 4   -> 26
pla                     // 5   -> 34
plp                     // 4   -> 26
jml $000500             // 4   -> 24
TOTAL:                  // 93  -> 610

qwertymodo (NO MSU-1):

Spoiler:

Code: [Select]

php                     // 3   -> 20
rep #$30                // 3   -> 18
pha                     // 4   -> 28
lda.l msuFound          // 6   -> 40
beq call_nmi_fast       // 3   -> 18
call_nmi_fast:          //
pla                     // 5   -> 34
plp                     // 4   -> 26
jml $000500             // 4   -> 24
TOTAL:                  // 32  -> 208

Download v1.1.4: https://mega.nz/folder/wIE1gQ5S#rbpeeX5pcNFAXfV9XVt2bA

EDIT: Fixed Master Clock cycles calculation by correctly multiplying stack access cycles by 8.
EDIT: Replaced download link.
EDIT: Added support for the french translation.
EDIT: Added extra features to the make scripts.

Chronosplit · « **Reply #446 on:** August 16, 2021, 08:33:26 pm »

Noted! Interesting that all the other patches have the same problem.

Quote from: Cthulhu88 on August 06, 2021, 05:36:53 pm

Some NPCs in Medina refer to Magus and Lavos in the same sentence/area too.

Ugh... Nintendo of America and its censorship. It was so much easier for the original creators because his original name meant both things.
Hey... Let's censor everything religion related but name three plot characters after mythological christian characters. I am surprised they didn't censor the cathedral after censoring "Ten".

I am not a fan of Woolsey's "translation" myself; unfortunately the DS version, despite what people say, is NOT the definitive version for this game. The graphics look like garbage, the extra areas are awful and the extra items are overpowered to the point of breaking huge sections of the game (see Spekkio lv99).

Yeah, the translation situation is in a weird spot and I'm first to admit it. There's a certain point where I can't address something because the sources are spotty about it and/or it's out of scope of this hack. There are times where Slattery does appear to absolutely screw it up in comparison too, but I could see where one could prefer it. Either way it looks like I'm going to be putting in a new playthrough of the DS version soon to get to the bottom of some of these things.

One day I hope that we see Chrono Trigger get the same amount of script attention FFVI does. No, I don't mean hundreds of whole script hacks but scripts using whole new sources.

Cthulhu88 · « **Reply #447 on:** August 20, 2021, 10:59:17 am »

Found some issues with the manifest.bml included with the hack (which was written by me).
Snes9x and bsnes do not require it, but here is a fixed version for emulators that do (this will work on any Chrono Trigger ExHiROM supporting MSU-1):

Code: [Select]

cartridge region=NTSC
  rom name=program.rom size=0x600000
  ram name=program.srm size=0x2000
  map id=rom address=00-3f:8000-ffff base=0x400000
  map id=rom address=40-7d:0000-ffff base=0x400000
  map id=rom address=80-bf:8000-ffff mask=0xc00000
  map id=rom address=c0-ff:0000-ffff mask=0xc00000
  map id=ram address=20-3f,a0-bf:6000-7fff mask=0xe000

  msu1
    rom name=chrono_msu1.msu
    map id=io address=00-3f,80-bf:2000-2007
    track number=1 name=chrono_msu1-1.pcm
    track number=2 name=chrono_msu1-2.pcm
    track number=3 name=chrono_msu1-3.pcm
    track number=4 name=chrono_msu1-4.pcm
    track number=5 name=chrono_msu1-5.pcm
    track number=6 name=chrono_msu1-6.pcm
    track number=7 name=chrono_msu1-7.pcm
    track number=8 name=chrono_msu1-8.pcm
    track number=9 name=chrono_msu1-9.pcm
    track number=10 name=chrono_msu1-10.pcm
    track number=11 name=chrono_msu1-11.pcm
    track number=12 name=chrono_msu1-12.pcm
    track number=13 name=chrono_msu1-13.pcm
    track number=14 name=chrono_msu1-14.pcm
    track number=15 name=chrono_msu1-15.pcm
    track number=16 name=chrono_msu1-16.pcm
    track number=19 name=chrono_msu1-19.pcm
    track number=20 name=chrono_msu1-20.pcm
    track number=21 name=chrono_msu1-21.pcm
    track number=22 name=chrono_msu1-22.pcm
    track number=23 name=chrono_msu1-23.pcm
    track number=24 name=chrono_msu1-24.pcm
    track number=27 name=chrono_msu1-27.pcm
    track number=28 name=chrono_msu1-28.pcm
    track number=29 name=chrono_msu1-29.pcm
    track number=30 name=chrono_msu1-30.pcm
    track number=31 name=chrono_msu1-31.pcm
    track number=35 name=chrono_msu1-35.pcm
    track number=36 name=chrono_msu1-36.pcm
    track number=37 name=chrono_msu1-37.pcm
    track number=38 name=chrono_msu1-38.pcm
    track number=39 name=chrono_msu1-39.pcm
    track number=40 name=chrono_msu1-40.pcm
    track number=41 name=chrono_msu1-41.pcm
    track number=42 name=chrono_msu1-42.pcm
    track number=43 name=chrono_msu1-43.pcm
    track number=44 name=chrono_msu1-44.pcm
    track number=45 name=chrono_msu1-45.pcm
    track number=46 name=chrono_msu1-46.pcm
    track number=47 name=chrono_msu1-47.pcm
    track number=48 name=chrono_msu1-48.pcm
    track number=49 name=chrono_msu1-49.pcm
    track number=50 name=chrono_msu1-50.pcm
    track number=51 name=chrono_msu1-51.pcm
    track number=54 name=chrono_msu1-54.pcm
    track number=56 name=chrono_msu1-56.pcm
    track number=57 name=chrono_msu1-57.pcm
    track number=59 name=chrono_msu1-59.pcm
    track number=60 name=chrono_msu1-60.pcm
    track number=61 name=chrono_msu1-61.pcm
    track number=62 name=chrono_msu1-62.pcm
    track number=63 name=chrono_msu1-63.pcm
    track number=64 name=chrono_msu1-64.pcm
    track number=66 name=chrono_msu1-66.pcm
    track number=68 name=chrono_msu1-68.pcm
    track number=69 name=chrono_msu1-69.pcm
    track number=70 name=chrono_msu1-70.pcm
    track number=72 name=chrono_msu1-72.pcm
    track number=73 name=chrono_msu1-73.pcm
    track number=77 name=chrono_msu1-77.pcm
    track number=78 name=chrono_msu1-78.pcm
    track number=80 name=chrono_msu1-80.pcm
    track number=81 name=chrono_msu1-81.pcm
    track number=82 name=chrono_msu1-82.pcm
    track number=84 name=chrono_msu1-84.pcm
    track number=85 name=chrono_msu1-85.pcm

board region=ntsc
  rom name=program.rom size=0x600000
    map address=00-3f:8000-ffff base=0x400000
    map address=40-7d:0000-ffff base=0x400000
    map address=80-bf:8000-ffff mask=0xc00000
    map address=c0-ff:0000-ffff mask=0xc00000
  ram name=program.srm size=0x2000
    map address=20-3f,a0-bf:6000-7fff mask=0xe000

  msu1
    map address=00-3f,80-bf:2000-2007
    rom name=msu1.rom
    track number=1 name=chrono_msu1-1.pcm
    track number=2 name=chrono_msu1-2.pcm
    track number=3 name=chrono_msu1-3.pcm
    track number=4 name=chrono_msu1-4.pcm
    track number=5 name=chrono_msu1-5.pcm
    track number=6 name=chrono_msu1-6.pcm
    track number=7 name=chrono_msu1-7.pcm
    track number=8 name=chrono_msu1-8.pcm
    track number=9 name=chrono_msu1-9.pcm
    track number=10 name=chrono_msu1-10.pcm
    track number=11 name=chrono_msu1-11.pcm
    track number=12 name=chrono_msu1-12.pcm
    track number=13 name=chrono_msu1-13.pcm
    track number=14 name=chrono_msu1-14.pcm
    track number=15 name=chrono_msu1-15.pcm
    track number=16 name=chrono_msu1-16.pcm
    track number=19 name=chrono_msu1-19.pcm
    track number=20 name=chrono_msu1-20.pcm
    track number=21 name=chrono_msu1-21.pcm
    track number=22 name=chrono_msu1-22.pcm
    track number=23 name=chrono_msu1-23.pcm
    track number=24 name=chrono_msu1-24.pcm
    track number=27 name=chrono_msu1-27.pcm
    track number=28 name=chrono_msu1-28.pcm
    track number=29 name=chrono_msu1-29.pcm
    track number=30 name=chrono_msu1-30.pcm
    track number=31 name=chrono_msu1-31.pcm
    track number=35 name=chrono_msu1-35.pcm
    track number=36 name=chrono_msu1-36.pcm
    track number=37 name=chrono_msu1-37.pcm
    track number=38 name=chrono_msu1-38.pcm
    track number=39 name=chrono_msu1-39.pcm
    track number=40 name=chrono_msu1-40.pcm
    track number=41 name=chrono_msu1-41.pcm
    track number=42 name=chrono_msu1-42.pcm
    track number=43 name=chrono_msu1-43.pcm
    track number=44 name=chrono_msu1-44.pcm
    track number=45 name=chrono_msu1-45.pcm
    track number=46 name=chrono_msu1-46.pcm
    track number=47 name=chrono_msu1-47.pcm
    track number=48 name=chrono_msu1-48.pcm
    track number=49 name=chrono_msu1-49.pcm
    track number=50 name=chrono_msu1-50.pcm
    track number=51 name=chrono_msu1-51.pcm
    track number=54 name=chrono_msu1-54.pcm
    track number=56 name=chrono_msu1-56.pcm
    track number=57 name=chrono_msu1-57.pcm
    track number=59 name=chrono_msu1-59.pcm
    track number=60 name=chrono_msu1-60.pcm
    track number=61 name=chrono_msu1-61.pcm
    track number=62 name=chrono_msu1-62.pcm
    track number=63 name=chrono_msu1-63.pcm
    track number=64 name=chrono_msu1-64.pcm
    track number=66 name=chrono_msu1-66.pcm
    track number=68 name=chrono_msu1-68.pcm
    track number=69 name=chrono_msu1-69.pcm
    track number=70 name=chrono_msu1-70.pcm
    track number=72 name=chrono_msu1-72.pcm
    track number=73 name=chrono_msu1-73.pcm
    track number=77 name=chrono_msu1-77.pcm
    track number=78 name=chrono_msu1-78.pcm
    track number=80 name=chrono_msu1-80.pcm
    track number=81 name=chrono_msu1-81.pcm
    track number=82 name=chrono_msu1-82.pcm
    track number=84 name=chrono_msu1-84.pcm
    track number=85 name=chrono_msu1-85.pcm

information
  title:    Chrono Trigger MSU-1
  name:     chrono_msu1.sfc
  region:   NA
  revision: 1.0

the_E_y_Es · « **Reply #448 on:** August 26, 2021, 08:14:00 pm »

Do you have plans for changing the speech pattern of the characters in the Middle Ages to match Frog's? I seem to remember you saying something to that effect. Probably wishful thinking on my part.

Chronosplit · « **Reply #449 on:** August 26, 2021, 09:50:23 pm »

Quote from: the_E_y_Es on August 26, 2021, 08:14:00 pm

Do you have plans for changing the speech pattern of the characters in the Middle Ages to match Frog's? I seem to remember you saying something to that effect. Probably wishful thinking on my part.

I haven't forgotten, last year just was.. itself. I was in talk with another user over last year I believe about their attempt at it, things kinda just drifted off.

It's still in the back of my mind, and I may redouble my efforts at it after this update depending on the look of the situation.

the_E_y_Es · « **Reply #450 on:** August 27, 2021, 11:38:50 am »

No worries, I can wait. Even without the circumstances, any long-term hack like this one is an incredibly taxing endeavor. Sometimes you just have to put it on hold/hiatus.

On a side note, I do prefer "Sky" to "Lightning". More elegant IMO.

The new equipment translations look like they would benefit from a VWF; you'd have more space to fit the longer names.

Cthulhu88 · « **Reply #451 on:** September 05, 2021, 03:03:20 am »

Is this a vanilla thing? Mismatching the description with the actual tech name?

Near the Mystic Mountains?

Chronosplit · « **Reply #452 on:** September 05, 2021, 05:00:25 pm »

Quote

Is this a vanilla thing? Mismatching the description with the actual tech name?

Yeah, the tech description is a vanilla thing and it isn't supposed to be the name. There's a lot of shortening involved in the descriptions, because the game wasn't really built to give long descriptions to anything at all unlike what the DS version has (and those are all US only from what I can tell). That's what made the item descriptions what they are.

Quote

Near the Mystic Mountains?

I don't have the scripts in front of me and Chrono Compendium is down at the moment, but that one's unchanged. I can give it a redressing though, it's probably supposed to say that the portal's near the mystic mountain one.

Cthulhu88 · « **Reply #453 on:** September 05, 2021, 08:46:31 pm »

Quote from: Chronosplit on September 05, 2021, 05:00:25 pm

Yeah, the tech description is a vanilla thing and it isn't supposed to be the name. There's a lot of shortening involved in the descriptions, because the game wasn't really built to give long descriptions to anything at all unlike what the DS version has (and those are all US only from what I can tell). That's what made the item descriptions what they are.

Yeah, tech descriptions are mostly useless, but this one doesn't make sense; damage techs are generally "Attack enemy w/ {tech name}".
Also, Robo--Glacier is longer than Ice Tackle (13 tiles vs 10 tiles, not counting compressed tiles).

Cthulhu88 · « **Reply #454 on:** September 20, 2021, 12:37:51 pm »

Another one that you might consider looking at.

Chronosplit · « **Reply #455 on:** September 23, 2021, 05:48:19 pm »

Quote from: Cthulhu88 on September 20, 2021, 12:37:51 pm

Another one that you might consider looking at.

Oof, original text strikes again. The line before that is word for word, but this one according to the retranslation script:

"There should be one in the Middle Ages who
needs to take that in hand and defeat Magus.
I assume you can't handle it on your own?"

Yeah, there's a lot missing there that I'll need to fix.

Cthulhu88 · « **Reply #456 on:** September 23, 2021, 06:35:49 pm »

Just so you know, I've taken a break from the game.
Since I already know the story from beginning to end and the game has almost no RPG elements, replaying feels like rewatching a movie; the OCD isn't making it any fun either.

My save is just outside the Cursed Woods, ready to deliver the Masamune to Frog.
I believe I've covered everything related to Magus up to that point, except for the fiends in the cathedral and Medina (which you are well aware of).

Chronosplit · « **Reply #457 on:** September 23, 2021, 08:43:01 pm »

Quote from: Cthulhu88 on September 23, 2021, 06:35:49 pm

Just so you know, I've taken a break from the game.
Since I already know the story from beginning to end and the game has almost no RPG elements, replaying feels like rewatching a movie; the OCD isn't making it any fun either.

My save is just outside the Cursed Woods, ready to deliver the Masamune to Frog.
I believe I've covered everything related to Magus up to that point, except for the fiends in the cathedral and Medina (which you are well aware of).

Noted. I still need to do a DS version run. After that I might start hammering out things, gonna take a while though.

Author Topic: Chrono Trigger Bugfix and Uncensoring Patch (Read 193743 times)

Cthulhu88

Re: Chrono Trigger Bugfix and Uncensoring Patch

Chronosplit

Re: Chrono Trigger Bugfix and Uncensoring Patch

Cthulhu88

Re: Chrono Trigger Bugfix and Uncensoring Patch

Chronosplit

Re: Chrono Trigger Bugfix and Uncensoring Patch

Cthulhu88

Re: Chrono Trigger Bugfix and Uncensoring Patch

Cthulhu88

Re: Chrono Trigger Bugfix and Uncensoring Patch

Chronosplit

Re: Chrono Trigger Bugfix and Uncensoring Patch

Cthulhu88

Re: Chrono Trigger Bugfix and Uncensoring Patch

the_E_y_Es

Re: Chrono Trigger Bugfix and Uncensoring Patch

Chronosplit

Re: Chrono Trigger Bugfix and Uncensoring Patch

the_E_y_Es

Re: Chrono Trigger Bugfix and Uncensoring Patch

Cthulhu88

Re: Chrono Trigger Bugfix and Uncensoring Patch

Chronosplit

Re: Chrono Trigger Bugfix and Uncensoring Patch

Cthulhu88

Re: Chrono Trigger Bugfix and Uncensoring Patch

Cthulhu88

Re: Chrono Trigger Bugfix and Uncensoring Patch

Chronosplit

Re: Chrono Trigger Bugfix and Uncensoring Patch

Cthulhu88

Re: Chrono Trigger Bugfix and Uncensoring Patch

Chronosplit

Re: Chrono Trigger Bugfix and Uncensoring Patch