Okay, I have checked out the weapon switching.
This is a bit more complex it seems.
Your code works well, but it takes away a few important original features.
The original system is made so, that you always have the best possible weapon on screen automaticially.
In the unpatched game, if you start a new game, you have only the Handgun. You can not switch to the Knife
The knife is the last resourt if you are out of ammo. It is actually not there to be a full weapon. It is to weak.
in its current state. You can not make a play through with the knife like in resident evil.
That is why you can not choose it manually.
Also Handgun, Sturmgewehr and Chaingun is the same type of Weapon and use the same type of Ammo.
If you collect a new weapon like the Sturmgewehr in the first Level, the game switches directly
to the new and more powerful weapon. And you can not go back. Its like a permanent upgrade of the weapon type.
You can also say he throws the old weapon away and takes the new one.
If you have the Chain Gun for example and you are depleating your ammo,
the game switches to the knife (when there is no Flame Thrower and/or the Rocket Launcher in your arsenal).
If you now collect new ammo for the weapons, the game is directly switching back from the knife
to the Chain Gun.
If you have the Chain and find the Flame Thrower or the Rocket Launcher, it switches
to them but also enables weapon manual switching because you need to use them more carefully
There is less available ammo for them.
If you have the Flame Thrower and/or the Rocket Launcher in your arsenal already
and you depleating your ammo for the chain gun it won't switch to the knife but
instead to the Flame Thrower or the Rocket Launcher. It seems it switches
in this case to the next more powerful weapon available.
If you have wasted all your ammo for all weapons, the switches to the knife until you
found ammo for either the Guns, the flame thrower or the Rocket Launcher.
So switching through all weapons is actually not a feature of the game.
If we do that, it needs to be optional without changing the original way you collect guns.
In the V6 patch manual weapons switching is now a must.
I actually forgot to switch and was
playing until the end of level 2 just with the Handgun XD
In its current state the weapon change hack is not usable in the pure uncut.
But it could be very interesting for future haks since this alters the gameplay quite a bit.
It makes the game harder aswell since you need to take care about your weapon.
I want to propose something for the weapon switching. This is an improvement also for the Uncut.
The unpatched game uses Select for weapon switching.
This is not the best choice.
Most people use the left thumb to control the D-Pad and Select.
So if you switch the weapons, you can not walk for a moment.
The game uses X and Y for fast run. It is quite pointless to use two
buttons for that.
I would instead use X button for weapon change.
We could use only X and disable Select or we use both so that
Select switches back and X forth.
Thanks for the explaination of the sprites.
Okay, lets wait for Squall_FF8s feedback
Edit: his feedback was faster than my post
Okay, lets see.