News: 11 March 2016 - Forum Rules

Author Topic: Chrono Trigger Bugfix and Uncensoring Patch  (Read 194782 times)

luchario

  • Newbie
  • *
  • Posts: 1
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #420 on: August 25, 2020, 11:21:49 pm »
Excited to try this patch! Just found it for the first time, looking into using the canoe patch.

Curious, how many changes are missing from the Canoe patch vs the most updated version now? How would someone go about trying to implement all those new changes into a new Canoe patch?

Thank you for all your work! It's very much appreciated and quite inspiring.

Sdub

  • Jr. Member
  • **
  • Posts: 5
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #421 on: August 26, 2020, 12:10:13 am »
I've never really thought of that, but I don't really think I'd want to do it.  In Antiquity, at least the enlightened ones do well enough to separate themselves from other eras when it comes to lines.

I'm really sorry I meant to say the Dark Ages? The era Frog comes from.

vivify93

  • Submission Reviewer
  • Hero Member
  • *****
  • Posts: 1188
  • Guardian of Mystery
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #422 on: August 26, 2020, 03:21:17 pm »
Frog comes from the Middle Ages
All my life I've tried to fight what history has given me.

Sdub

  • Jr. Member
  • **
  • Posts: 5
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #423 on: August 26, 2020, 04:48:36 pm »
Frog comes from the Middle Ages

Thank you for the correction

Chronosplit

  • Hero Member
  • *****
  • Posts: 1588
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #424 on: August 27, 2020, 07:36:09 pm »
Excited to try this patch! Just found it for the first time, looking into using the canoe patch.

Curious, how many changes are missing from the Canoe patch vs the most updated version now? How would someone go about trying to implement all those new changes into a new Canoe patch?

Thank you for all your work! It's very much appreciated and quite inspiring.
By now, I can safely say "a lot" and just leave it at that.  You can probably go back to the last time that version was updated, and then after that everything was either not done or needs looked at.  Canoe was behind on updates before the Fiend/Fiendlord change, not to mention stuff like missing the whole item description shakeup and a bunch of smaller changes.

Temporal Flux doesn't work with Canoe since the patch basically converts it into a whole other ROM.   Way back when Primpinelephant was doing canoe updates, it was  basically examining the code via hex and making the changes that way.  But now that there's a new graphics hack in the mix and no one left any clue as to how sluffy did this, it's kinda anyone's guess how to handle that.  Last graphics issue had to do with banks, but I sure couldn't tell you the location.
« Last Edit: September 08, 2020, 07:44:45 pm by Chronosplit »

Dzumeister

  • Full Member
  • ***
  • Posts: 200
  • Zaubermancer
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #425 on: October 31, 2020, 02:20:05 pm »
By now, I can safely say "a lot" and just leave it at that.  You can probably go back to the last time that version was updated, and then after that everything was either not done or needs looked at.  Canoe was behind on updates before the Fiend/Fiendlord change, not to mention stuff like missing the whole item description shakeup and a bunch of smaller changes.

Temporal Flux doesn't work with Canoe since the patch basically converts it into a whole other ROM.   Way back when Primpinelephant was doing canoe updates, it was  basically examining the code via hex and making the changes that way.  But now that there's a new graphics hack in the mix and no one left any clue as to how sluffy did this, it's kinda anyone's guess how to handle that.  Last graphics issue had to do with banks, but I sure couldn't tell you the location.

does this mean there are no plans to make updated Canoe patches?
free sluffy

Cthulhu88

  • Jr. Member
  • **
  • Posts: 79
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #426 on: July 01, 2021, 12:17:29 am »
Not sure if you're still working on this, but...

Only NPC in Truce that mentions Magus instead of "The Fiendlord".

Also, since I haven't messed with CT since 2019, I went ahead and checked the changes you've made to this hack and caught this:
Quote
Also, added an anti-MSU1 patch to it's folder for the rare chance that you would need it, as I did run into someone who required it.
Why did he need that?

Chronosplit

  • Hero Member
  • *****
  • Posts: 1588
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #427 on: July 01, 2021, 08:59:03 am »
Not sure if you're still working on this, but...

Only NPC in Truce that mentions Magus instead of "The Fiendlord".
Darn it.  I'm not really active on it, but I may or may not get to this eventually.

Quote
Why did he need that?
At some point someone did actually get the FMV version to work on their ROM, but it required removing the existing one.  I don't really know much more outside of that, there is more talk about how to make it work late in that thread.  Since the FMVs still aren't finished your MSU-1 version is the better one either way, but there's a reason for an anti-patch to be present there's no reason not to include it.

Cthulhu88

  • Jr. Member
  • **
  • Posts: 79
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #428 on: July 01, 2021, 08:03:22 pm »
At some point someone did actually get the FMV version to work on their ROM, but it required removing the existing one.  I don't really know much more outside of that, there is more talk about how to make it work late in that thread.  Since the FMVs still aren't finished your MSU-1 version is the better one either way, but there's a reason for an anti-patch to be present there's no reason not to include it.

If you are referring to this post:
Quote
For anyone trying to get this to work with the Bugfix and Uncensoring patch, try renaming your patched file and the msu patch to chrono_msu, instead of chrono_msu1 like it says in the included directions. I was at wits end trying to get this to work, and that solved it for me. Hopefully this will help people searching in the future.
Check out my latest post in that thread.
Also, he is 100% running the code I've adapted to your hack, the reason he needed to rename the ROM is because his PCMs are named chrono_msu-X.pcm instead of chrono_msu1-X.pcm.
If that was the only thing required to run MSU-1 on your hack (notice that my patch is newer than qwertymodo's), I wouldn't have gone through all that trouble writing and tweaking a new code for it.

As for the person who got the FMVs in, I assume he is running Darkshock's IPS patch combined with the original intro FMV IPS patch.
Darkshock's patch will have tons of problems with your hack, such as not running NMI fade-ins/outs, aswell as running into many problems that are also present in the vanilla ROM, such as getting certain areas muted after a battle.
Basically you would be trading a properly written MSU-1 soundtrack code for one full of issues with a crappy quality FMV intro.

I mean, it does make sense to include a patch to remove MSU-1, but only if the person is going to do pretty much what I did and add his own MSU-1 code aswell as add the game events through Temporal Flux to support in-game FMVs. This is a huge amount of work though; not many are capable/willing of doing such tasks.


P.S.

Is this the person? https://www.youtube.com/watch?v=B_XQmpaNX4s
Video was released after MSU-1 was added to the hack.
Quote
-Chrono Trigger: Bugfix and Uncensoring Patch (Rebuilt Fd) by  Chronosplit.
Mentions Darkshock's patch:
Quote
-Chrono Trigger MSU-1 hack v1.1 by Darkshock.
And you can clearly read what I've described above in one of his comments:
Quote
I have here a version without the FMV watermark and also a patch prior to the current MSU-1 that joins the video to the new soundtrack and is compatible with the various hacks and retranslations of Chrono Trigger, unfortunately it has a serious bug that disables any music after a battle and that only comes back after leaving the area, to resolve this we must wait for the original author to release its final corrected version, something that we won't have anytime soon, I'm sorry.

I am not trying to sound aggressive and/or rude, I am just curious whether that person properly patched-in the FMVs or this is just misinformation that is leading him to damaging his ROM with a not suitable MSU-1 code.
The only other proper MSU-1 patch around is qwertymodo's, and you CANNOT patch that into Bugfix and Uncensor without asm. For FMVs you also need to edit the ROM with Temporal Flux as to add specific events to trigger the FMVs, exception being the intro.

Chronosplit

  • Hero Member
  • *****
  • Posts: 1588
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #429 on: July 02, 2021, 09:34:45 am »
You're right, and that's what confuses me about it.  I was never even able to get past the first text.

The anti-patch dates a good while before that post.  I was actually contacted by PM long before that by someone who was somehow using the FMVs before the new MSU-1 got put in.  I did state the problems I've had with the FMV version breaking everything in half, but thought "well okay, it never hurts to futureproof because maybe over time this will improve."  I was wrong, but I was also never given exactly how they did it.

I always thought I was missing something after that, but maybe it's just that no one's testing the FMVs through the entire game?

Cthulhu88

  • Jr. Member
  • **
  • Posts: 79
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #430 on: July 02, 2021, 10:28:55 am »
You're right, and that's what confuses me about it.  I was never even able to get past the first text.

What first text?

I always thought I was missing something after that, but maybe it's just that no one's testing the FMVs through the entire game?

I really doubt they've FMVs past the intro, like in the video posted above.
Qwertymodo's hack is the only one with support for FMVs other than the intro, and as I've mentioned, the amount of work required to patch that into your hack would be similar or greater than the amount of work I had to properly patch the MSU-1 soundtrack into it.

Anyway, you should add a disclaimer to not use Darkshock's hack with yours; even if you disregard everything I've already said, there are some data it patches that are moved elsewhere in your hack.
If you patch Darkshock's hack before yours, yours will overwrite those datas and some features will not work and/or outright deadlock the game, if you patch Darkshock's hack after yours, it will corrupt those addresses by writing to the old locations.

If people are really that desperate for those crappy FMVs, there are only two logical courses of action:
1: Switch to the vanilla ROM and use qwertymodo's hack.
2: Watch them on the web at greater quality.

The third would've been what I've already said about porting qwertymodo's code and events into your hack, but you must remember that qwertymodo ended up burnt trying to solve all the issues that arised.

Chronosplit

  • Hero Member
  • *****
  • Posts: 1588
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #431 on: July 02, 2021, 10:35:45 am »
Quote
What first text?
Like, the game literally wouldn't go past the first textual conversation with FMVs.  Not long after "good morning" because either the calls overwrite text or they're stored in different places.

I'll add a disclaimer next update.  it's nice to finally get clarification about the whole thing, and I'm sure some other peple are going to agree.

Cthulhu88

  • Jr. Member
  • **
  • Posts: 79
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #432 on: July 03, 2021, 12:14:56 am »
I'll add a disclaimer next update.  it's nice to finally get clarification about the whole thing, and I'm sure some other peple are going to agree.

In theory, the original intro hack made by smkdan should be compatible with your hack, but I CANNOT guarantee it does not write to invalid addresses. A quick look told me it doesn't, but I am not going to research this because I neither care nor want the FMVs into my game.

I cannot find smkdan's IPS patch, but if you can, simply patch the vanilla ROM with it then apply your patch on top.

You can also cross-assemble it on top of the vanilla ROM from qwertymodo's conversion of smkdan's code (for bass v14 syntax) and then patch your hack in.

Steps 4, 5 and 6 need to be done if you patch it via IPS too.

Whatever you do, don't include this as part of your hack as I haven't really done any meaningful research on possible issues.
If this ends up working for you, simply include a doc explaining on how to add the FMV intro if the person so desires.

EDIT:

ROM region used by the intro hack is free for the vanilla ROM, but not for your hack:
Code: [Select]
>>> p = Path("chrono_msu1.sfc")
>>> d = p.read_bytes()
>>> s = d[0x1CE000:]
>>> hexlify(s[:0x200])
b'1109114009120918092c02904b44096e02d06f099002d091100998099902c0ae09c2450200c302b0cb09df0200e05102b0e809fc0200fd02b005140a1902001a02b0220a4
40acc0200cd02b0dc0ae84102d0e90af60af702c003100b100b1102c01d0b2a040b2b02c0370b440b455102c0510b5b02005c02b067140b7102007202b07d0b874502008802
d0d30be5040be702c0e80bfa0bfc2102c0fd0b0b0c02c80c0c821a02d01b0c270c2902c0202a0c450c5502c0560c086d0c7402c0750c8c0c029702c0166d400603100003e30
016fe010001100101100a0800f0f1020a43ad0a02000c43020e43e7102000020633ad06d2000400020433ad20040a4400020a45ad30e6fc00880700ad1c0034ad101c101108
ad020230950508320508340500e60442085080e6040407001052000031090840e6fc07201e0840e6020007080865066dd40200dae301b24ae00b7e0003e400002f120013000
5003be40e1c0f1d2129003be4013b013f081f803be4003b003f27080060023b023f16280030183c55'
>>> p2 = Path("Chrono Trigger (USA).sfc")
>>> d2 = p2.read_bytes()
>>> s2 = d2[0x1CE000:]
>>> hexlify(s2[:0x200])
b'00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
000000000000000000000000000000000000000000000000000000000000000000000000000000000'

So, find a HiROM region that has about 1 KB of free address in both the vanilla ROM aswell as your hack (yes, it must be a HiROM region unless you change his seek macro) and change these two lines:
  • seek($DCE000) -> seek(FastROM address of the free region, 16 bits aligned preferably, aka, any even address)
  • seek($DCE0AA) -> seek(above address + 0xAA/170)

July 05, 2021, 06:16:56 am - (Auto Merged - Double Posts are not allowed before 7 days.)
Another one:


NPCs linked to the Magus statue also says Magus instead of Fiendlord, but I guess it makes sense for them?
« Last Edit: July 05, 2021, 06:16:56 am by Cthulhu88 »

Chronosplit

  • Hero Member
  • *****
  • Posts: 1588
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #433 on: July 05, 2021, 03:32:30 pm »
Hm, there's another one.  There are tons in Middle Ages in that room, I thought I got them all.  Yes actually, the statue ones saying Magus is correct since they're in disguise and such.

Cthulhu88

  • Jr. Member
  • **
  • Posts: 79
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #434 on: July 07, 2021, 04:25:27 pm »
I came across a very minor issue with MSU-1 due to my overzealous sanity checks.
At Bangor Dome, the "Mystery from the Past" song only plays the first time you use the crest door. This happens because there is no background music there to go back to, the code assumes the song is still playing and refuses to play it again.

Fixed it by simply checking whether MSU-1 is playing or not before refusing to play the same song.
Code: [Select]
        cpx.b Track.CURRENT
        bne +
        MSU.not_playing(Mode.ABS, .Exit)

This is a pretty small issue that doesn't break anything; the crest door song plays again as long as you leave and re-enter Bangor Dome, but here is version 1.1.3 of the MSU-1 code in case this issue happens elsewhere.

https://mega.nz/file/ZUVHRAQD#e523zi00aAnK45FN8ZeCatLiAG6S19ccyBS0FzNB5-s

Cthulhu88

  • Jr. Member
  • **
  • Posts: 79
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #435 on: July 22, 2021, 06:31:36 pm »

Chronosplit

  • Hero Member
  • *****
  • Posts: 1588
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #436 on: July 26, 2021, 10:45:12 am »

Hoo boy, this is starting to look like a bigger thing than just one or two lines.

I want to make sure that I've hit them all in every patch this time around, so this fix might take a bit longer than I originally thought.

Cthulhu88

  • Jr. Member
  • **
  • Posts: 79
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #437 on: July 26, 2021, 03:00:35 pm »
Hoo boy, this is starting to look like a bigger thing than just one or two lines.

I want to make sure that I've hit them all in every patch this time around, so this fix might take a bit longer than I originally thought.

This is a very OCD playthrough; I am talking to everything multiple times (damn this disorder to hell).
If you can wait, I'll end up giving you all the lines that you need to fix.
Bear in mind that I don't play every day though.

I also did come across commas inside quotes when they should've been placed after, and this format:
new line: {sentence}
new line: {single word}
new line: {sentence}
But I thought posting them in here would be considered hardcore nitpicking, so I let them slide.

Chronosplit

  • Hero Member
  • *****
  • Posts: 1588
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #438 on: July 27, 2021, 05:33:59 pm »
This is a very OCD playthrough; I am talking to everything multiple times (damn this disorder to hell).
If you can wait, I'll end up giving you all the lines that you need to fix.
Bear in mind that I don't play every day though.
I can definitely do that.

Quote
I also did come across commas inside quotes when they should've been placed after, and this format:
new line: {sentence}
new line: {single word}
new line: {sentence}
But I thought posting them in here would be considered hardcore nitpicking, so I let them slide.
Those commas actually might be worth looking into.  There are some grammar errors in the original script that I didn't correct, and I wouldn't be opposed to addressing them.

The format errors might be a case-by-case basis.  Some of this is probably due to space limits or auto-correcting by Temporal Flux, some were like that in the first place.

AuronSerge0123

  • Newbie
  • *
  • Posts: 1
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #439 on: July 28, 2021, 01:50:06 pm »
So I wasn't sure if this is the appropriate place to post this, but I found that Time Rock Orchestra would like to contribute his remastered track for Chrono Trigger; I saw him post in the Chrono Compendium forums. Here is his YouTube profile (https://www.youtube.com/channel/UCJVAwIJZabtM8y-XiOZ-Dtg), take a look at his Chrono Trigger playlist; all his tracks are great.