They don't allow hacks that make games compatible with emulators. It discourages emulator authors from fixing compatibility. It's a detriment to make emulators more compatible.
Given the fixes in question are for a solar sensor I doubt flash cart makers (curious as to why the OP mentioned everdrive when their GBA offering has been available for probably less than a week at this point, wonder if they have become short hand for flash cart like R4 did in DS flash carts) or emulator devs are going to do much there -- it is not a sort your timing issues or get better accuracy so you don't trip anti piract issue as much as things that are not there. Had this been the pokemon real time clock fix (most emulators that matter will handle it, possibly even pull from system clock) then yeah I would question the merits but light sensors are generally absent on most things, unless you want to try to contrive something with a webcam. I don't know where I would find myself with the tilt sensor patches now many phones could conceivably emulate/replicate it.
The main problem for me is the rest of that thread has some really good stuff in (all the custom versions and refinements of the basic solar patch) so the thing some view as a cop out of making it a doc instead is probably the better route, especially as it makes a nice worked intro to some applied assembly.
In either case I am not going to lose any sleep over it, so to speak, but