News: 11 March 2016 - Forum Rules
Current Moderators - DarkSol, KingMike, MathOnNapkins, Azkadellia, Danke

Author Topic: Banana (Translation) [KingMike]  (Read 919 times)

firedropdl

  • Full Member
  • ***
  • Posts: 108
    • View Profile
Banana (Translation) [KingMike]
« on: December 31, 2017, 11:32:34 pm »
Hey KingMike,

I just wanted to verify something with you.  It's regarding your Banana translation here: http://www.romhacking.net/translations/1578/

It says to use the following rom:

Banana (J).nes (with Header)
CRC32: 5AC41464

I just noticed that when you hit the select button to go into a menu and leave the menu, the screen doesn't refresh and you move your character around the menu screen instead of the actual game.  It turns out that the verified "Good" dump "[!]", the same CRC on the page, does this as well.

There are several "Bad" dumps out there that don't have this issue.  The one I'm going to try patching now is known as "Banana (J) [b1][o1].nes" in GoodNES 3.23b and as "Banana (1986-09-08)(Victor Ongaku Sangyou)(JP)[h Vimm][mapper 3, iNES title].nes" in TOSEC, and has a CRC value of E7CAC9EF.

I was wondering if you could verify which version you used when making this translation.  I will update my findings after I re-patch this version.



EDIT:  Before posting this, I noticed your translation page says this:

Quote
Please note the needed ROM. Last I was aware, GoodNES thinks the proper ROM is 40KB. Note that is actually a bad dump! The GoodNES “mapper 3 hack” is 64KB, and is supported by the “banana-e.ips” patch, but that too is a bad dump. The ROM really should be 48KB. Use the “banana48K” translation patch on that one. (so, maybe the “p1″ or “p1 a1″ ROM is right. I don’t know. I just trimmed the 64K ROM myself.)

I'm showing the Good rom is 49,168 bytes, not 40k. (GoodNES 3.23b).

I do see that the "Banana (J) [b1][o1].nes" rom is 65,680 bytes, so I'm assuming this is the one you used. 


Please verify this whenever you get the time.  If it works and you're in agreement that this is the proper rom, I can submit a change to the page for the proper rom to use if you'd like. 

Thanks!



January 01, 2018, 09:04:19 am - (Auto Merged - Double Posts are not allowed before 7 days.)
Okay... I patched that version and it seems to work fine. :)

Just hoping to hear that this is the one you used.
« Last Edit: January 01, 2018, 09:04:19 am by firedropdl »

KingMike

  • Forum Moderator
  • Hero Member
  • *****
  • Posts: 6481
  • *sigh* A changed avatar. Big deal.
    • View Profile
Re: Banana (Translation) [KingMike]
« Reply #1 on: January 01, 2018, 11:10:56 am »
Maybe Good tools has since corrected which one is "bad". I know at the time of the patch though, the GoodNES "good" ROM was 40K.

It was so many years ago I can't remember but most likely I started with a 64KB ROM with "DiskDude!" header corruption.
CRC32: F480AB04
MD5: D3D6DCDE78A8D47342394368C55764CF
SHA-1: 5E859A6FA12809335DD8F8C99C7FC867EC23F619
The patch removes "DiskDude!" as well (just zero all those bytes), so it should work on a ROM with or without it.

Removing the DiskDude! from the 64KB ROM gives
CRC32: AEF78148
MD5: 317B932FFAD54F8994D82D562B3B87E7
SHA-1: 7386FF0A68CE1B0DBCA62574578776FE88A6D892

The 64KB ROM manually trimmed to 48KB is
CRC32: 30A7BA60
MD5: 0404B111D31375B9286F7A8FC9AEF18D
SHA-1: A1B6F171754E767E949AEE714FB8527B94337D0D

To create the 48KB ROM from the 64KB ROM, I'm sure I just cut out the last 16KB in a hex editor. (64KB = 32KB PRG-ROM + 2 copies of the 16KB CHR-ROM)

I've seen someone complain about another hack I released about why bothering with this "DiskDude!" shit.
Maybe now it has been cleaned out of ROMs but they must've not lived through this (regularly loading games in emulators and having them not working, needing to thus open the hex editor and manually fix it).  :P
Quote
Sir Howard Stringer, chief executive of Sony, on Christmas sales of the PS3:
"It's a little fortuitous that the Wii is running out of hardware."

firedropdl

  • Full Member
  • ***
  • Posts: 108
    • View Profile
Re: Banana (Translation) [KingMike]
« Reply #2 on: January 02, 2018, 08:18:35 am »
Hmmm... lol... I don't know anything about DiskDude!  First I've heard about it.

F480AB04 isn't even in GoodNES 3.23b.

The AEF78148 is though.  It's named "Banana (J) [b3].nes", and it's 65,552 bytes.

I patched "Banana (J) [b1][o1].nes" with a CRC of E7CAC9EF yesterday and it seems to work fine.  But I guess I wouldn't know unless I played the whole game through.


Would you recommend that I patch AEF78148 with the "banana-e.ips" (Non 48k) patch then? 

KingMike

  • Forum Moderator
  • Hero Member
  • *****
  • Posts: 6481
  • *sigh* A changed avatar. Big deal.
    • View Profile
Re: Banana (Translation) [KingMike]
« Reply #3 on: January 02, 2018, 11:48:06 am »
Yes, the "e" patch is for 64KB. But it's probably better to use the 48K patch on the 48K ROM since that is the correct size.

I don't know, and I don't know if many others, even know the origin of DiskDude!. Just that it was some crap that turned up in many non-working ROMs. We can only guess it came about very early in the days of emulation, possible even the days when Nesticle was updated. As it overwrote part of the mapper number, which is what caused it to bug out or crash on most emulators. Most versions of Nesticle (I think including 0.42, the final and most uploaded Windows version) I believe only supported mappers through 15, thus only using through byte 0x6 of the header. (though not ALL mappers 0-15. No MMC4 (10), which I'd guess was little known then since it was only used in three Japanese games (Famicom Wars and the two Fire Emblem games) that, at that time, would've been little known to the west.
Quote
Sir Howard Stringer, chief executive of Sony, on Christmas sales of the PS3:
"It's a little fortuitous that the Wii is running out of hardware."

firedropdl

  • Full Member
  • ***
  • Posts: 108
    • View Profile
Re: Banana (Translation) [KingMike]
« Reply #4 on: January 03, 2018, 04:44:01 am »
lol... DiskDude!

Sorry.  I think my question was confusing.  I realize the 48k patch is for a 48k rom.

I'm asking you if I should patch AEF78148 "Banana (J) [b3].nes" file instead of the one that I patched that seems to work fine.


The one I patched was "Banana (J) [b1][o1].nes" with a CRC of E7CAC9EF.