News: 11 March 2016 - Forum Rules
Current Moderators - DarkSol, KingMike, MathOnNapkins, Azkadellia, Danke

Author Topic: Chrono Trigger Bugfix and Uncensoring Patch  (Read 97538 times)

Cthulhu88

  • Jr. Member
  • **
  • Posts: 62
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #400 on: September 30, 2019, 04:16:33 pm »
Updated the MSU-1 patch with a sanity check for when MSU-1 volume is 0, but memory volume is not.

I've already said it before, but I do hope this is the last of it.

Chronosplit

  • Hero Member
  • *****
  • Posts: 1408
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #401 on: September 30, 2019, 06:32:18 pm »
Updated the MSU-1 patch with a sanity check for when MSU-1 volume is 0, but memory volume is not.

I've already said it before, but I do hope this is the last of it.
And once again, thanks a ton for your work! :beer:

I just wanted to say that I'm looking forward to trying this hack as soon as you get your update out that you mentioned. It looks great! I recently played through the DS version.
Thanks!

Current status: I'm hoping to get the rest finished by sometime day after tomorrow.  Do not quote me on this, but that is the plan.

Cthulhu88

  • Jr. Member
  • **
  • Posts: 62
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #402 on: October 01, 2019, 01:18:43 pm »
I've just figured out why I can't access mega.nz. The corrupt and incompetent judicial system of my country just banned mega.nz. The lawsuit that led to this isn't even public (how transparent), but apparently involves copyright bullshit.
Until this gets overruled, I'll have to use a VPN to access mega.nz.

Chronosplit

  • Hero Member
  • *****
  • Posts: 1408
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #403 on: October 01, 2019, 06:59:09 pm »
I've just figured out why I can't access mega.nz. The corrupt and incompetent judicial system of my country just banned mega.nz. The lawsuit that led to this isn't even public (how transparent), but apparently involves copyright bullshit.
Until this gets overruled, I'll have to use a VPN to access mega.nz.
Oh dear.  Thanks for the heads up, I'll be looking at the alternatives for those who can't use Mega then.  I think a few browsers still have issues anyway.  At least there's still RHDN itself!

Also good news everyone, finally got the tile assembly corrected.  You'll definitely be seeing an update sometime tomorrow.

EDIT: One last thing, differing from the tutorial I learned two more things:

1. 00 for some reason would not bring up a blank, but FF did.  Also, a new tile should be put in the tile before the numbers.  I used a blank under the chronometer images and it didn't work too well.
2. The tiles for "Ages" in Dark Ages are the last two in the assembly.  In fact, the es tile is the very last byte.  Look for the 5C behind that and you're done.
« Last Edit: October 01, 2019, 09:23:02 pm by Chronosplit »

Cthulhu88

  • Jr. Member
  • **
  • Posts: 62
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #404 on: October 01, 2019, 09:00:34 pm »
Hopefully the MSU-1 code works without any further updates. Just make sure you never use these spaces: $CD5D05 up to $CD5DA0 (this gives me 128 bytes, in case I need to increase the tracklist), $CDF9B9 up to $CDFFFF (all of it, for further code expansion, if necessary).
These spaces have all their bytes initialized to $FF in vanilla, so it's easy to check if TF moved stuff in there.

Once I am confident MSU-1 works without any further issue, I might started a new project, Deus Chrono: Trigger Ex, Chrono Trigger MSU-1 Music with the Deus Ex soundtrack.
Just imagine: UNATCO Theme playing at Guardia Castle, Paris Cathedral as the Cathedral Theme, Ocean Lab Theme at the Ocean Palace, etc.  ;D

Chronosplit

  • Hero Member
  • *****
  • Posts: 1408
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #405 on: October 01, 2019, 10:59:05 pm »
Hopefully the MSU-1 code works without any further updates. Just make sure you never use these spaces: $CD5D05 up to $CD5DA0 (this gives me 128 bytes, in case I need to increase the tracklist), $CDF9B9 up to $CDFFFF (all of it, for further code expansion, if necessary).
These spaces have all their bytes initialized to $FF in vanilla, so it's easy to check if TF moved stuff in there.
I'll note that in the readme along with the graphics area.  I'm pretty sure those are the only areas I need to bring up.

Quote
Once I am confident MSU-1 works without any further issue, I might started a new project, Deus Chrono: Trigger Ex, Chrono Trigger MSU-1 Music with the Deus Ex soundtrack.
Just imagine: UNATCO Theme playing at Guardia Castle, Paris Cathedral as the Cathedral Theme, Ocean Lab Theme at the Ocean Palace, etc.  ;D
Sounds like fun!

October 01, 2019, 11:43:19 pm - (Auto Merged - Double Posts are not allowed before 7 days.)
Welp, here we are.  I lied.  New version's in the Mega, and will be uploaded soon to RHDN.  Boy, does it feel good to finally get this out the door.

Code: [Select]
-Added MSU-1
-Epoch’s time select now contains Prehistory and Antiquity.
-Updated the End of Time line that talks about Prehistoric minerals (the only time the era is actually referenced).
-Fixed the main ending still having a Magus’s Army reference.

And a few words about what's next:
-I guess I have some Medieval speech to tend to.  But after a break, and I’ll probably make a new thread for it where everyone can yell at me about it.  I may even tackle another game first though, I've been eyeing Pokemon Crystal for a while.

-You’ll notice that on RHDN, the version number is now Rebuilt F.  F stands for final in that when talking about text, I truly do not think there’s anything left to do.  I'll still be around to tackle bugfixes and the like (make sure to keep me updated if you find anything), but I think we have reached the end of what I feel Bugfix and Uncensoring can and should achieve in the script area.  Even if something happened like Tomato came out with a new comparison, I would probably only do a couple of edits.  Outside of typos from me or adding gameplay fixes, here’s the end of the line.
 -All that said, if you'd rather things be more like the DS version or whathaveyou... my stuff is here to use, you're free to edit.  If you need anything just ask.

-I’ve marked the Canoe folder with (OLD) because I’m not particularly sure about the fate of it at this point.  Sorry to everyone who uses it.  The age name changes throw a whole other monkey wrench in, because I already know that graphic alterations don’t play well with it (which makes sense, the patch basically coverts CT to sdd1 so fixing Sky/Dark graphics alone required 1a).  With sluffy unfortunately not around, I fear that I won’t be able to do a complete update to it.  On the bright side, the other patches should work just fine in every snes9x core (yes that’s right, emus that can’t use it should just pass over MSU-1).
« Last Edit: October 02, 2019, 12:09:05 am by Chronosplit »

Cthulhu88

  • Jr. Member
  • **
  • Posts: 62
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #406 on: October 02, 2019, 04:24:25 pm »
Just two things to point out:
  • In the MSU-1 Readme you mention to rename the ROM to chrono_msu when it should be chrono_msu1.
  • This is just formalities, but could you please include the license for the MSU-1 code or the code itself (which has the license)? The license credits everyone who worked on implementing MSU-1 into Chrono Trigger aswell as add a disclaimer that none of them are responsible for any damages that it could cause (very unlikely to happen).

Also, my romhack has some specific macros for compatibility with yours. Did the offsets for Charm, Twin Charm and Charm Top descriptions and cat food reward amounts change?

Descriptions:
  • $F68417
  • $F686ED
  • $F6F5B4
Cat food:
  • $DBDB63
  • $DBDBC7
  • $DBD8FC

Chronosplit

  • Hero Member
  • *****
  • Posts: 1408
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #407 on: October 02, 2019, 04:41:51 pm »
Just two things to point out:
  • In the MSU-1 Readme you mention to rename the ROM to chrono_msu when it should be chrono_msu1.
  • This is just formalities, but could you please include the license for the MSU-1 code or the code itself (which has the license)? The license credits everyone who worked on implementing MSU-1 into Chrono Trigger aswell as add a disclaimer that none of them are responsible for any damages that it could cause (very unlikely to happen).
Oh shoot, yeah I'll get onto that ASAP.  Probably just the license though.
EDIT: Done!

Quote
Also, my romhack has some specific macros for compatibility with yours. Did the offsets for Charm, Twin Charm and Charm Top descriptions and cat food reward amounts change?

Descriptions:
  • $F68417
  • $F686ED
  • $F6F5B4
Cat food:
  • $DBDB63
  • $DBDBC7
  • $DBD8FC
They shouldn't have changed in this update, I haven't really done much with item descriptions in general since the equipment description overhaul with elements etc. a good while back.  The only minor strings that saw any change between the last update and this are the time period names that appear in the game save menu.
« Last Edit: October 02, 2019, 04:59:58 pm by Chronosplit »

Cthulhu88

  • Jr. Member
  • **
  • Posts: 62
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #408 on: October 02, 2019, 05:58:39 pm »
I forgot to mention it might be wise to add the Lavos' Theme info into the readme. Apologizes.

Chronosplit

  • Hero Member
  • *****
  • Posts: 1408
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #409 on: October 02, 2019, 09:52:10 pm »
I forgot to mention it might be wise to add the Lavos' Theme info into the readme. Apologizes.
Thanks for reminding me about that because I did completely forget.  I'll file that into the readme for a later update and put it in the Mega, but I won't put it on RHDN right away so as not to completely clog the queue with my updates. There's still the possibility that I may need to fix something, after all.
« Last Edit: October 02, 2019, 10:54:23 pm by Chronosplit »

redmagejoe

  • Jr. Member
  • **
  • Posts: 90
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #410 on: November 22, 2019, 03:30:51 pm »
Not to suggest that this is the patch author's issue, but this seemed like the most appropriate place to bring it up.

https://www.romhacking.net/hacks/21/

This is a rather old hack, so I'm not surprised that it hasn't been maintained, especially not relative to recent releases. That said, I did thorough troubleshooting and found that the Bugfix + Uncensoring Patch does not play nice with the Coliseum patch, and I am eager to run both in tandem if at all possible. The game boots fine, and I don't see anything that would be considered gamebreaking... yet. However, during the title screen "movie" with the various gameplay cutscenes, if Coliseum is applied on top of Bugfix+Uncensor (and all other patches I've compared play nicely), once the movie reaches the point after Robo gets his ass kicked by other robots, right before the scene where Crono and Marle drag him into the dome on the world map, the game will softlock. Music will continue to play, but the screen is black, and no inputs seem to allow you to return to the title screen. A reset is necessary.

I suppose my question is, is there any easy or feasible way to address this? Is the issue because there's a new structure on that part of the world map that the "movie" doesn't load, and thus the game locks up? If that were the case, it would be isolated to the patch in question I would think, yet it seems to be an interference between your patch and Coliseum. What might I be able to change to make these two work together, or is it a lost cause? Thank you in advance.

EDIT: Troubleshooting was as follows: (A = Unsightly Pixel, B = Frog Powerup Patch, C = Unused Music) Clean ROM + Coliseum works. Coliseum ROM + all combinations of A, B, and C work. Bugfix + Uncensor ROM works, as do all combinations of A, B, and C. Only when Clean ROM + Bugfix+Uncensor + Coliseum are together does the "movie" hang.

Mauron

  • Submission Reviewer
  • Hero Member
  • *****
  • Posts: 540
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #411 on: November 22, 2019, 11:45:59 pm »
Bugfix and Coliseum are both trying to use the same free space for something, and it crashes when trying to access that part of the ROM. Coliseum would have to be redone with this hack in mind to get it working.
Mauron wuz here.

redmagejoe

  • Jr. Member
  • **
  • Posts: 90
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #412 on: November 22, 2019, 11:48:37 pm »
Bugfix and Coliseum are both trying to use the same free space for something, and it crashes when trying to access that part of the ROM. Coliseum would have to be redone with this hack in mind to get it working.
Damn, that's a shame... Looking at the release date, I doubt that the original author is even around to consider such an undertaking. What a bummer, this seemed like a fun "bonus content" patch in lieu of the Nintendo DS or PSX content.

Chronosplit

  • Hero Member
  • *****
  • Posts: 1408
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #413 on: November 23, 2019, 11:28:24 pm »
Bugfix and Coliseum are both trying to use the same free space for something, and it crashes when trying to access that part of the ROM. Coliseum would have to be redone with this hack in mind to get it working.
Exactly this.  At one point early on I had actually had a thought of putting it in and giving my own spin on things, maybe even do crazy things like add the unused weapons, but it was too late and the issue was already there.


One more minor patch on the way, but the date I have on it is "before Christmas."  Thanks to TheMagus for bringing this up because I didn't know, but the PS1 version actually corrected a couple of enemy names.  So far I have Shiitake and Schist, but I'll be tracking down a change list to see if there are any more just to make sure.  GolemBoss's stutter is now correctly hyphenated too (if you're reading this: sorry but a hyphen is the same amount of space as "..." due to how the font character works in CT, so no space change!)

I'll also be doing a light bit of work on a version of Bugfix Alone that believe it or not, reverts the change to Fiends only.  Fiendlord stays.  This was also an idea from TheMagus as a middle-of-the-road idea, and while I originally turned it down I feel that some might be happy with it.

EDIT: Alright, took a gander at and... apparently only one changed at that time.  Schist is from DS, but it's a similar whoopsie to Shiitake so I'll still use it.

November 29, 2019, 10:08:14 pm - (Auto Merged - Double Posts are not allowed before 7 days.)
Something else interesting I picked up while running through wizard and mystic lines: in Keeper's Dome, the line that mentions Magus is a bit of a consistency error.  It should be talking about how Lavos appeared after being summoned, not how he was summoned away to somewhere else.  Belthazar is obviously recanting sightings of Lavos mentioned in history.
« Last Edit: December 01, 2019, 10:30:52 pm by Chronosplit »

Chronosplit

  • Hero Member
  • *****
  • Posts: 1408
    • View Profile
Re: Chrono Trigger Bugfix and Uncensoring Patch
« Reply #414 on: December 01, 2019, 04:21:54 pm »
Done!

Code: [Select]
-Shist>Schist
-Shitake>Shiitake
-Fixed the Keeper's Dome line that mentions Magus
-Added Mystics folder.  For now it contains only the Bugfix Alone version, but I may or may not come back around and do the rest later.

EDIT: I'm not going to re-upload for this outside of the mega, but there's a very short blurb in the Mystics folder (honestly there's nothing I haven't said here) that's just a file.  That's a txt file that somehow didn't save with it's extension, just add it and it's readable.
« Last Edit: December 02, 2019, 12:07:21 pm by Chronosplit »