Romhacking.net

Romhacking => ROM Hacking Discussion => Topic started by: columbo on June 07, 2017, 04:04:18 pm

Title: Zelda 2 FDS Translation
Post by: columbo on June 07, 2017, 04:04:18 pm
I looked and couldn't find a patch for Zelda 2 on the Famicom Disk System, so I decided to try and translate it myself.

Thanks largely to a script comparison put out by the guys that did the retranslation found here:
http://www.glitterberri.com/adventure-of-link/retranslation/

I've put together a patch that changes the dialog to English.  It leaves in a lot from the original USA release, plus I corrected a few things, shortened a lot and changed a thing or two. You can download it at this mega link.

https://mega.nz/#!cC413ZYb!xd78wM9Ja8oL0WVZ_RsG692eX9pgNxOcS0WNt7zUIOw

I've hardly tested this thing, so if you're interested I would love some feedback.  Plus if the dialog completely fudges up at some point you can let me know.  I'm going to test it as well, but I'm not sure how fast I'll be getting through the game.  It's been a while since I've played and this version may be harder than the original.

Here's the md5 sum of the original rom:
e230433a97b88b08d4ad58c76ba268e6  Legend of Zelda 2, The - Link no Bouken (Japan) (v1.1).fds

Here's the sha1 sum of the original rom:
8877321f1fda7d54bf2468dd6f5e36d321cbcce1  Legend of Zelda 2, The - Link no Bouken (Japan) (v1.1).fds



Moderator Note: Was moved out of Personal Projects because it's moreso for WIP projects.
Title: Re: Zelda 2 FDS Translation
Post by: zstandig on June 08, 2017, 03:25:40 pm
I played up to the towns and everything seemed okay (using FCEUX)

I have a powerpak and tried that and got a 'bad header' error.  (That's from the powerpak not the disksystem rom)

However the powerpak uses the disksytem rom is probably the culprit as I've never been able to get any fds hacks or translations to work properly.
Title: Re: Zelda 2 FDS Translation
Post by: Ya Dad on June 26, 2017, 08:30:24 am
I have an FDS Stick that I am going to try this with on a real Famicom Disk System. I'm still waiting on my FDS to come in through the mail, so I'll report back when it arrives.
Title: Re: Zelda 2 FDS Translation
Post by: FCandChill on June 29, 2017, 06:51:37 pm
Nice job. Out of curiosity, does the FDS hardware have the ability to display variable width font..? NES carts with enough VRAM can. This could help you put in more text but you could always expand the textboxes.
Title: Re: Zelda 2 FDS Translation
Post by: KingMike on June 30, 2017, 09:19:56 pm
Really the only requirement is VRAM, with enough free tiles to hold an entire window worth of text, as well as enough free RAM to use as a buffer for rendering the VWF text. As well vblank time to transfer the data from RAM to VRAM.

The FDS uses VRAM, whether the rest is sufficient depends on the game. (the FDS has more RAM, but that's because it NEEDS it to store program code/data loaded from the disk. You can't execute code off the disk directly.)

I think I looked at Zelda II's textboxes briefly once (on the NES) and I recall it draw each line of the window as a string of border/space tiles. Whether or not you could scrape up enough free space for a replacement routine to generate the window from different sized dimensions, I don't know.
Title: Re: Zelda 2 FDS Translation
Post by: Asaki on July 03, 2017, 08:17:50 am
Whether or not you could scrape up enough free space for a replacement routine to generate the window from different sized dimensions, I don't know.

I think getting rid of the double-spacing (which a few games, like Dragon Warrior, did) would give plenty of space without having to resize the windows.
Title: Re: Zelda 2 FDS Translation
Post by: moritasan2040 on July 27, 2017, 06:26:47 am
Looks great, Columbo. Thanks for this. I can't believe it hadn't been done sooner. I'll be trying it out on my NES Classic, so I'll let you know how that goes. Luckily the FCD version is easier (in my opinion) becuz you can max out your strength faster.
Title: Re: Zelda 2 FDS Translation
Post by: KingMike on July 27, 2017, 11:52:11 am
You know though if you get a Game Over you lose all that, though?
(upon Game Over, it sets your levels back to the lowest one of the three. People originally thought it was a bug but that is actually intended behavior. There is an NPC which warned you to raise levels evenly. In the localization it was changed to something else like "When all else fails, use fire." since that version decided to make a couple enemies require the Fire spell to kill.)
Title: Re: Zelda 2 FDS Translation
Post by: 8.bit.fan on July 27, 2017, 04:22:30 pm
This is great, can't wait to try it!
I've always preferred the Japanese version because of the sound/music.

Thanks for this! :)
Title: Re: Zelda 2 FDS Translation
Post by: moritasan2040 on July 28, 2017, 09:46:28 am
You know though if you get a Game Over you lose all that, though?
(upon Game Over, it sets your levels back to the lowest one of the three. People originally thought it was a bug but that is actually intended behavior. There is an NPC which warned you to raise levels evenly. In the localization it was changed to something else like "When all else fails, use fire." since that version decided to make a couple enemies require the Fire spell to kill.)
Wow. I didn't know that. I guess I never got far enuf to get a game over. I think I've only beaten the first palace.
Title: Re: Zelda 2 FDS Translation
Post by: jordiway73 on August 24, 2017, 01:24:22 am
http://www.romhacking.net/translations/3177/

I only found 1 error and fixed (get it error lol)

(http://i64.tinypic.com/2ijkgl.png)

flashpv updated the title screen

(http://i65.tinypic.com/14tvk7q.png)

missing copyright symbol was fixed hope you enjoy


Title: Re: Zelda 2 FDS Translation
Post by: Kallisto on August 27, 2017, 02:15:57 am
Did you find anything different about this game compared to the NES version? How did the music sound like?
Title: Re: Zelda 2 FDS Translation
Post by: Abster on August 31, 2017, 04:46:03 pm
Some pretty major issues with this translation patch.  Not seeing a whole lot with the actual script so far but there are other issues.

Namely, items not spawning.  Their locations are essentially identical to the NES release.  Among items not spawning are magic and heart containers, bonus exp bags, and most importantly, items that are required to learn certain spells essential to completing the game, like the trophy that teaches you the jump spell.  I can't go beyond the first palace without the jump spell.
Title: Re: Zelda 2 FDS Translation
Post by: dACE on September 01, 2017, 09:33:17 am
flashpv updated the title screen

(http://i65.tinypic.com/14tvk7q.png)

missing copyright symbol was fixed hope you enjoy

Sanctuaris should perhaps be spelled Sanctuaries?

/dACE
Title: Re: Zelda 2 FDS Translation
Post by: KingMike on September 01, 2017, 12:37:03 pm
Did this patch not fix the bad English that was in the original game title sequence? :P
("SANCTUARIS" being one of the original mistakes)

"AWAKEN THE ANOTHER SLEEPING PRINCESS ZELDA"
Title: Re: Zelda 2 FDS Translation
Post by: jordiway73 on September 05, 2017, 12:15:49 pm
No all the original Engrish was kept intact

here is the newest patch to fix the missing items

http://www.mediafire.com/file/jccgfhn8c4w0dv7/Zelda22.7z

need some people to play this all the way through to make sure there are no more bugs
Title: Re: Zelda 2 FDS Translation
Post by: Abster on September 06, 2017, 02:04:26 am
Ok, it looks like the items are back in the game proper, now I can kinda dig through this.

Most of the issues seem to be some dialogue locations being incorrect.

In Saria
(https://i.imgur.com/FuKOspg.png) (https://i.imgur.com/zLYdGUr.png)(https://i.imgur.com/nWf2Bx2.png)
The purple Bot has two dialogues.  The first of which the first 3 times you speak to it, and the other happening when you speak to it at least 4 times.  It is initially sleeping and then tells you Bug's location after you speak to it at least 4 times.  Right now the hint is the first thing it says instead of the second.  I have no idea what the "F...." is for, but I found the dialog for when it's supposed to be sleeping.  Right now Bug is the one who's sleeping instead. XD 
(https://i.imgur.com/UNvtd1S.png)  A missing "a" in "may" in this shot, when the riverman grants you access to the bridge after you see Bug.

From Mido...
(https://i.imgur.com/r2f09hF.png)  Bug's correct dialogue is currently being used by the swordman who teaches you the downstab.
(https://i.imgur.com/H7jguxY.png)  While the swordman's correct dialogue is being used by the magician who teaches you the Fairy spell.
(https://i.imgur.com/0z0hw4H.png)  The magician's dialogue is being used by an NPC who at least in the American version asks you to visit Error in Ruto for a hint as to the Island Palace location.
(https://i.imgur.com/4qFkrph.png)  Here the "Mido" line can be moved down to the next line instead of bleeding onto the dialogue box as it is now.

Those are the errors I see so far.
Title: Re: Zelda 2 FDS Translation
Post by: columbo on September 06, 2017, 11:11:11 am
No all the original Engrish was kept intact

here is the newest patch to fix the missing items

http://www.mediafire.com/file/jccgfhn8c4w0dv7/Zelda22.7z

need some people to play this all the way through to make sure there are no more bugs

What was the deal with the items missing?  Did I overwrite something I shouldn't have?  Or was that just in the updated patch?

September 06, 2017, 01:50:25 pm - (Auto Merged - Double Posts are not allowed before 7 days.)
Ok, it looks like the items are back in the game proper, now I can kinda dig through this.

Most of the issues seem to be some dialogue locations being incorrect.

In Saria
(https://i.imgur.com/FuKOspg.png) (https://i.imgur.com/zLYdGUr.png)(https://i.imgur.com/nWf2Bx2.png)
The purple Bot has two dialogues.  The first of which the first 3 times you speak to it, and the other happening when you speak to it at least 4 times.  It is initially sleeping and then tells you Bug's location after you speak to it at least 4 times.  Right now the hint is the first thing it says instead of the second.  I have no idea what the "F...." is for, but I found the dialog for when it's supposed to be sleeping.  Right now Bug is the one who's sleeping instead. XD 
(https://i.imgur.com/UNvtd1S.png)  A missing "a" in "may" in this shot, when the riverman grants you access to the bridge after you see Bug.

From Mido...
(https://i.imgur.com/r2f09hF.png)  Bug's correct dialogue is currently being used by the swordman who teaches you the downstab.
(https://i.imgur.com/H7jguxY.png)  While the swordman's correct dialogue is being used by the magician who teaches you the Fairy spell.
(https://i.imgur.com/0z0hw4H.png)  The magician's dialogue is being used by an NPC who at least in the American version asks you to visit Error in Ruto for a hint as to the Island Palace location.
(https://i.imgur.com/4qFkrph.png)  Here the "Mido" line can be moved down to the next line instead of bleeding onto the dialogue box as it is now.

Those are the errors I see so far.

Ahh.  Good info!  Looks like I have some work to do.
Title: Re: Zelda 2 FDS Translation
Post by: jordiway73 on September 06, 2017, 04:28:48 pm
It seems there are no good dumps of this game to be downloaded anywhere on the net every place I found had the same bad dump. So I had a friend dump his and send it to me,then I was able to fix the issue.


I'm not sure how much space you have to work with, when it comes to adding more text. I know I had very little when it came to the first Zelda game.

The best advice I can give you it to save it for where its needed most, and steal it from where its not needed like towns people saying Hello could be Hi instead.

Let me know if you need any help and make sure you use the current patch for editing
Title: Re: Zelda 2 FDS Translation
Post by: xttx on September 06, 2017, 11:06:02 pm
I cant get this game to run at all in nestopia. It always throws the same error corrupt or missing file. anything i might be missing here?

It worked before patch 2.2 but now the newest patch 2.2 will not work on nestopia. It throws an cpu jam/corrupt file.

In trying to get the items to appear I think the changes corrupt the image for nestopia.

Check this thread out:

https://forums.nesdev.com/viewtopic.php?f=10&t=12911

The missing items is actually a common problem that is remedied quite easy. Columbo, can you help to get this final version working on Nestopia again please?
Title: Re: Zelda 2 FDS Translation
Post by: KingMike on September 07, 2017, 12:19:33 pm
If the patch has since been fixed, then Nestopia is possibly still running a backup copy of the game.
However, I can't seem to find where Nestopia is putting it.
And wow is Windows 8's File Search function useless shit. It can't find the file or hell, even nestopia.exe as a test. :P

Okay, after Googling said Windows problem and then doing a search, it seems that the last official Nestopia (from 2008!) saves the game as a UPS patch (your Zelda II ROM filename + .ups) in the "Patch" directory defined in your Path settings in the emulator. Find and delete that file to erase your old save games, since that appears (from what I read) to be part of the problem.
Title: Re: Zelda 2 FDS Translation
Post by: columbo on September 07, 2017, 08:24:01 pm
Ok, well I made a new patch to apply to your rom that's already been patched up to 2.2.  Is that how this is supposed to work?  I dunno... If not I'll replace it later.

I fixed the dialog issues, and the text that was bleeding.

If I did something funky and there's a problem I'll fix it sometime soon. (It's past my bedtime right now though, so give me a day or two.)

Also worth noting:  If you bring yourself back to a town where the dialog was messed up with a save state from the old patch, you probably need to leave the town and come back for the dialog to be fixed.

Here's the patch: 
*ignore this patch.  use the new one i posted below.*

Let me know if it works out for you!  I think I need to start putting the patch number on the title screen.  Maybe next update I'll do that.

Edit: In fact, just think of this as a preview of the real patch that I'll put out soon.
Title: Re: Zelda 2 FDS Translation
Post by: xttx on September 07, 2017, 10:09:24 pm
Hey KingMike thanks for the reply. Deleting that save info does nothing. When i patch a clean rom with the ips patch it corrupts the game. In nestopia it comes up as corrupt file.

I made sure there were no old save files in those folders. This patch worked in previous versions but something is wrong and it will not work this time.

Can anything be done to get this to work?
Title: Re: Zelda 2 FDS Translation
Post by: columbo on September 07, 2017, 10:36:47 pm
Hey KingMike thanks for the reply. Deleting that save info does nothing. When i patch a clean rom with the ips patch it corrupts the game. In nestopia it comes up as corrupt file.

I made sure there were no old save files in those folders. This patch worked in previous versions but something is wrong and it will not work this time.

Can anything be done to get this to work?
I should have a newer patch in a few days.  If there is something wrong with the 2.2 patch, hopefully this will fix it.
Title: Re: Zelda 2 FDS Translation
Post by: xttx on September 07, 2017, 11:11:36 pm
I should have a newer patch in a few days.  If there is something wrong with the 2.2 patch, hopefully this will fix it.

I patched a clean rom with 2.2 and then added 2.3 on top of that. It still says corrupted rom in nestopia.

I will wait for the next patch to see if this will work.
Title: Re: Zelda 2 FDS Translation
Post by: columbo on September 08, 2017, 07:32:01 pm
Alright.  So as far as I can tell for whatever reason the 2.2 patch broke compatibility with Nestopia.

I went ahead and through some testing I think I can say I took the 2.1 patch and re-fixed the items that didn't spawn.  Then I went ahead and fixed the dialog glitches that were brought up.  I tested both of these in Nestopia, and then I tested it on the real hardware.  Everything should be set now (as far as known issues).  Here's the (hopefully fully working) 2.3 patch.

http://www.mediafire.com/file/d3e6fzqyabkel33/Zelda_2_.3_%28ENG%29.ips

On Saturday night or Sunday I plan on modifying the title screen to have a subtle "Ver. 2.3" added to it.  Then I'll see about replacing the patch listed on the romhacking.net page.

As far as the 2.2 patch goes, I had luck patching with Flips IPS and then playing it with FCUEX.  Not sure what the problem was with Nestopia.  I didn't look into it, but maybe it was missing a header or something.

Please give me any feedback you have on this new patch.  I want to have this game 100% tested so I can move on to another project.

Edit: Oh, and I'm just remembering I still need to fix the Town of Mido sign as well as typo where "my" should be "may".  Ughhh...Oh well.  I'll get that done before I submit the new patch to the site.  Guess that version will be 2.31 or something.
Title: Re: Zelda 2 FDS Translation
Post by: Abster on September 08, 2017, 08:39:50 pm
Aside from lacking an apostrophe in some words (Did Zelda 2 native even have one?)  The dialogue locations in western Hyrule seem to be fixed now.  There's only one other thing I found.
(https://i.imgur.com/QCAv0KB.png) 
There doesn't need to be a line break just for exclamation marks.  Moving onto eastern Hyrule the town of Nobooru does have its own fair share of errors though and those weren't fixed yet.

Also, 2.3 needs to be patched on top of 2.2.  Patching 2.3 by itself doesn't do anything.  :P
Title: Re: Zelda 2 FDS Translation
Post by: xttx on September 10, 2017, 01:48:27 am
Really? I patched 2.3 to a clean rom and it works perfect. For nestopia you cannot patch 2.2 or the emulator will show it as corrupt rom.
Title: Re: Zelda 2 FDS Translation
Post by: columbo on September 10, 2017, 08:05:05 pm
I've gone ahead and fixed the remaining minor dialog issues with the exception of missing apostrophes.  I also added a reference to the current patch number after the Nintendo copyright logo. 

This will be my last update for now unless someone finds some more bugs.  Was someone saying there were more dialog issues further in the game?  Maybe they deleted their post?  I did a once over of the script, and I didn't see anything, but make sure to report any errors so I can make sure this is working 100%.  I would greatly appreciate it.

I'll probably do some more testing myself, but once again, I'm not sure how fast I'll be making progress.  I plan on starting a new project tomorrow, so for now I'll be spending time on that.

This patch is for a fresh rom of the game.  I know I briefly did that patch of a patch thing, but not this time.

Patch version ENG 2.31
https://www.mediafire.com/file/yeag65rv235c11f/Zelda%202%20.31%20%28ENG%29.ips

Edit:
Moving onto eastern Hyrule the town of Nobooru does have its own fair share of errors though and those weren't fixed yet.
THIS is what I was thinking of.  If you can cite anything specific I'll try to fix it ASAP.
Title: Re: Zelda 2 FDS Translation
Post by: Abster on September 11, 2017, 07:33:08 am
Been caught up in my 2 IRL jobs right now so didn't have time to take screenshots.  I will do some work on Tuesday at least, because there's plenty more of those address errors. 
Title: Re: Zelda 2 FDS Translation
Post by: columbo on September 11, 2017, 03:58:09 pm
Been caught up in my 2 IRL jobs right now so didn't have time to take screenshots.  I will do some work on Tuesday at least, because there's plenty more of those address errors.
No worries!  Anything you can do to help is greatly appreciated!  I've definitely been a bit sleep deprived lately myself due to work related reasons.  I'm very grateful for anyone playing and finding bugs.

Welp...Another day another patch.  I looked over the script and I fixed something that will hopefully have all the later dialog working.  I'm hoping this means everything is good to go, but you never know.  I'll just leave this here:

http://www.mediafire.com/file/yptb86hxokmudd0/Zelda_2_.32_%28ENG%29.ips
Title: Re: Zelda 2 FDS Translation
Post by: Abster on September 24, 2017, 01:23:58 am
Looks like most of the pointer stuff has been fixed regarding dialogue locations.  There are some minor spelling errors that remain that I'll post here.

(https://i.imgur.com/HdMfwRE.png) V where a space should be.
(https://i.imgur.com/vj1B4DP.png) One L instead of two
(https://i.imgur.com/LBxtVGR.png) Not an error, but I'm not sure about the "yay!" at the end.
(https://i.imgur.com/ZSJfdua.png) Bleeding text here
(https://i.imgur.com/0L81B0k.png) Worse text bleeding at Darunia entrance sign
(https://i.imgur.com/1Q3ya9r.png) Darunia spelling error.
(https://i.imgur.com/y91HiSR.png) Again, one L instead of two
(https://i.imgur.com/UYyB7gl.png) Someones instead of "Somones"
(https://i.imgur.com/ntbb5YS.png) Finally, some garbage tiles in the game's ending for when Zelda wakes up.

That's everything I could find this go around.
Title: Re: Zelda 2 FDS Translation
Post by: KingMike on September 24, 2017, 10:51:50 am
(https://i.imgur.com/UYyB7gl.png) Someones instead of "Somones"
Should have an apostrophe, if you have one in the font. Otherwise, I'd spell it out "someone is" preferably, and "someone" if not.
Title: Re: Zelda 2 FDS Translation
Post by: abw on September 26, 2017, 10:40:30 pm
(https://i.imgur.com/y91HiSR.png) Again, one L instead of two
In fairness, I think this one is highly dependent on whether the translation is into actual English or just American :P.
Title: Re: Zelda 2 FDS Translation
Post by: Abster on September 27, 2017, 01:19:08 am
Who spells Travelers with 2 Ls?
Title: Re: Zelda 2 FDS Translation
Post by: Psyklax on September 27, 2017, 05:49:44 am
Who spells Travelers with 2 Ls?

British people. Seriously, man, how do you not know that? :D
Title: Re: Zelda 2 FDS Translation
Post by: KingMike on September 27, 2017, 02:02:20 pm
They're not grateful we took the fluff u's out of their language? :D
Title: Re: Zelda 2 FDS Translation
Post by: columbo on September 27, 2017, 02:19:11 pm
Looks like most of the pointer stuff has been fixed regarding dialogue locations.  There are some minor spelling errors that remain that I'll post here.

(https://i.imgur.com/HdMfwRE.png) V where a space should be.
(https://i.imgur.com/vj1B4DP.png) One L instead of two
(https://i.imgur.com/LBxtVGR.png) Not an error, but I'm not sure about the "yay!" at the end.
(https://i.imgur.com/ZSJfdua.png) Bleeding text here
(https://i.imgur.com/0L81B0k.png) Worse text bleeding at Darunia entrance sign
(https://i.imgur.com/1Q3ya9r.png) Darunia spelling error.
(https://i.imgur.com/y91HiSR.png) Again, one L instead of two
(https://i.imgur.com/UYyB7gl.png) Someones instead of "Somones"
(https://i.imgur.com/ntbb5YS.png) Finally, some garbage tiles in the game's ending for when Zelda wakes up.

That's everything I could find this go around.

Thanks for the update!  I'll try to get another patch out sometime over the weekend where I fix spelling errors and whatnot.  Not sure I'll fix the garbage tiles this go around, but I'll take a look at it.  Hopefully I just need to replace the sprites with the correct ones or something.  Not sure why that's happening.
Title: Re: Zelda 2 FDS Translation
Post by: firedropdl on September 27, 2017, 11:50:56 pm
Just wanted to show my support here columbo.  Thanks for all your work man.  Looking forward to playing this someday.  :)
Title: Re: Zelda 2 FDS Translation
Post by: RadioTails on September 28, 2017, 09:58:53 am
(https://i.imgur.com/ZSJfdua.png) Bleeding text here

Would it be better to have it displayed as:

THE TEMPLE
LIES EAST
OF NABOORU.


Who spells Travelers with 2 Ls?
Traveller's Tales (https://en.wikipedia.org/wiki/Traveller%27s_Tales), the British programmers who made Sonic R, Crash Bandicoot: The Wrath of Cortex, and all the broken lego games. :P
Title: Re: Zelda 2 FDS Translation
Post by: Abster on September 29, 2017, 12:37:43 am
So the 2 Ls is a British thing.  Duly noted.
Title: Re: Zelda 2 FDS Translation
Post by: columbo on September 30, 2017, 06:08:00 pm
I think I fixed everything Abster pointed out minus the glitch at the end of the game.  I used KingMike and RadioShadow's suggestions for how to fix those dialog boxes that were a little screwed up.

From what I can tell those garbage tiles at the end of the game are actually part of the title screen.  It might be an easy fix, but I haven't dived too deep into it since I wasn't the one who did the title screen hack.  I'll do a little more investigating to see if I can fix it without straight up removing the title screen hack. (edit: Doesn't look like any easy fix.  Definitely looks like the title screen hack replaces those sprites.  If you have any ideas let me know. There are some unused katakana sprites, but they aren't loaded into the PPU during the title screen.)

I'm going to update the wiki page with the new patch.   For now though you can use this link:

https://www.mediafire.com/file/0aui7rabdieukkk/Zelda%202%20.33%20%28ENG%29.ips
Title: Re: Zelda 2 FDS Translation
Post by: DemoniusX on October 02, 2017, 10:36:07 pm
Sorry to bring up this old thread but no matter what I do,when patching the game the file size goes to zero and won't load and I've tried 5 different v1.1 of Link No Bouken 2! Do I have to modify anything,why won't it patch. Using Lunar IPS to patch this game? Any ideas?
Title: Re: Zelda 2 FDS Translation
Post by: ShadowOne333 on October 03, 2017, 05:43:04 pm
I think I fixed everything Abster pointed out minus the glitch at the end of the game.  I used KingMike and RadioShadow's suggestions for how to fix those dialog boxes that were a little screwed up.

From what I can tell those garbage tiles at the end of the game are actually part of the title screen.  It might be an easy fix, but I haven't dived too deep into it since I wasn't the one who did the title screen hack.  I'll do a little more investigating to see if I can fix it without straight up removing the title screen hack. (edit: Doesn't look like any easy fix.  Definitely looks like the title screen hack replaces those sprites.  If you have any ideas let me know. There are some unused katakana sprites, but they aren't loaded into the PPU during the title screen.)

I'm going to update the wiki page with the new patch.   For now though you can use this link:

https://www.mediafire.com/file/0aui7rabdieukkk/Zelda%202%20.33%20%28ENG%29.ips

Are the correct sprites loaded at that section of the game?
If so, you might want to play around with the tile arrangement when that screen is visible.
Look for the incorrect sprites in the PPU Viewer, write down their Tile ID, then try to hunt the order in which the incorrect sprites appear in the Hex editor -> Rom viewer.

Then try changing them for the correct sprite Tile ID.
Hopefully that works. Of course, that's if the correct sprites are in the PPU Viewer at the correct moment.
Title: Re: Zelda 2 FDS Translation
Post by: columbo on October 09, 2017, 01:54:49 pm
Sorry to bring up this old thread but no matter what I do,when patching the game the file size goes to zero and won't load and I've tried 5 different v1.1 of Link No Bouken 2! Do I have to modify anything,why won't it patch. Using Lunar IPS to patch this game? Any ideas?
Sorry for the delayed response.  I used flips IPS for the latest patch.  I doubled checked to make sure it was still working for me.  flips is the newer version of Lunar IPS.  I think the patches are often smaller than the ones Lunar outputs and maybe that affects the compatibility somewhat.

If enough people have issues with compatibility then I'll definitely investigate to see what I can do about it.

Are the correct sprites loaded at that section of the game?
If so, you might want to play around with the tile arrangement when that screen is visible.
Look for the incorrect sprites in the PPU Viewer, write down their Tile ID, then try to hunt the order in which the incorrect sprites appear in the Hex editor -> Rom viewer.

Then try changing them for the correct sprite Tile ID.
Hopefully that works. Of course, that's if the correct sprites are in the PPU Viewer at the correct moment.

Not sure what to do here.  I haven't checked the ending, but at the beginning of the game when you're in the room with sleeping Zelda the katakana sprites aren't loaded.  The sprites loaded all seem like they go to something.

Perhaps an ASM hack could fix this, but honestly I'm not too worried about those missing sprites.

I'm guessing that a little bit of time went into the title hack so I feel like leaving that in for now out of respect, but another solution would be to just use the Japanese title screen, which does happen to say "The Legend of Zelda 2" above the Japanese text.

edit: Or maybe I could just release a separate patch here on the forums with the Japanese title screen.  If anyone wants that, let me know.
Title: Re: Zelda 2 FDS Translation
Post by: Psyklax on October 09, 2017, 02:17:05 pm
flips is the newer version of Lunar IPS.  I think the patches are often smaller than the ones Lunar outputs and maybe that affects the compatibility somewhat.

Sorry if I'm derailing the thread here, but can anyone explain to me the benefit of any patching programs besides Lunar IPS - or patch formats besides IPS? The size of the files is so minuscule that that's clearly not a problem, so what's better about the others? The only thing I know is that BPS files will throw an error if the checksum doesn't match, which is nice, but not that big of a deal.

Given the IPS format is so damn simple - go to this part, put this many bytes in, here are the bytes, lather rinse repeat - I don't see why there's a need to change it. Sure, when you get to something above 16-bit, it might need to be more sophisticated (it supports 24-bit addresses, so I guess any file above 16MB is a problem), but for most of the hacking that goes on here, it seems perfectly satisfactory.

Again, sorry for derailing your thread, I just didn't see the need to clutter the forum up with a new thread on this point. :D

[mods: feel free to move this to a new thread, or let me know if that would be a better thing to do...]
Title: Re: Zelda 2 FDS Translation
Post by: KingMike on October 09, 2017, 02:47:22 pm
Using BPS for an FDS game would be a bad idea, since (depending on the emulator) the save file is written to the ROM, so then the BPS would only match if you had identical save data, which is pretty much impossible. :P
(some emulators might instead make a copy of the ROM and save to that)

The other reason FDS files could not match up despite being good dumps is that, original disks had the date written stored in the standard Nintendo header part of the disk. We've seen that in more accurate dumps that have been made of FDS games lately.
In common FDS dumps that data is zeroed (though I'm not sure if it is relatable to 3DS ROMs, which as I understand typically have some fingerprinting data wiped out. It's going off topic though but the 3DS header wiping is more understandable though as it was probably made to track individual copies and maybe so Nintendo could ban from their network pirated copies and/or accounts of users who uploaded the ROMs.)
Title: Re: Zelda 2 FDS Translation
Post by: darkmoon2321 on October 09, 2017, 02:51:12 pm
Sorry if I'm derailing the thread here, but can anyone explain to me the benefit of any patching programs besides Lunar IPS - or patch formats besides IPS? The size of the files is so minuscule that that's clearly not a problem, so what's better about the others? The only thing I know is that BPS files will throw an error if the checksum doesn't match, which is nice, but not that big of a deal.

Given the IPS format is so damn simple - go to this part, put this many bytes in, here are the bytes, lather rinse repeat - I don't see why there's a need to change it. Sure, when you get to something above 16-bit, it might need to be more sophisticated (it supports 24-bit addresses, so I guess any file above 16MB is a problem), but for most of the hacking that goes on here, it seems perfectly satisfactory.

If I need to make an IPS patch, I pretty much only use Lunar IPS.  It's simple and I know it works.  But for larger hacks, typically those that involve expanding the ROM, moving large chunks of data, or editing compressed data, it's better to use a patch format that can handle data insertion.  For instance, if you insert a single byte into a long string, IPS will see every byte after the initial change as being different and will include the data in the patch.  This can lead to your patch containing copyrighted information.  In the case of expanded ROMS, the patch size for an IPS can be as big as the original ROM itself, and will undoubtedly contain copyrighted data.  IPS is more popular however, and the average user can apply a patch without having to go download a new patching tool.  So basically, I use IPS when I can, but for the more complicated projects, I'll use something that can handle data insertion, like BPS or xdelta.
Title: Re: Zelda 2 FDS Translation
Post by: Psyklax on October 09, 2017, 05:02:40 pm
Using BPS for an FDS game would be a bad idea, since (depending on the emulator) the save file is written to the ROM, so then the BPS would only match if you had identical save data, which is pretty much impossible. :P
(some emulators might instead make a copy of the ROM and save to that)

I know that. That was my point of saying I just use IPS. However...

But for larger hacks, typically those that involve expanding the ROM, moving large chunks of data, or editing compressed data, it's better to use a patch format that can handle data insertion.  For instance, if you insert a single byte into a long string, IPS will see every byte after the initial change as being different and will include the data in the patch.  This can lead to your patch containing copyrighted information.

This is exactly the problem I've got with my (as yet unreleased) Knight Lore translation for FDS. I added a few bytes to the file and thus the IPS file is 26KB instead of under 1KB, and obviously includes a large chunk of the disk. I don't want this, so if anyone can recommend an alternative then I'm all ears.

The checksum checking of BPS is a problem for the reason KingMike mentioned - though incidentally my patch deletes the save data, and I hope others making patches will do the same as it's probably appreciated by people who want a nice clean file. How about Xdelta? I've not used it, would it yield a better result in my case? Do you have to manually say where the extra bytes are or can it just figure it out by itself?
Title: Re: Zelda 2 FDS Translation
Post by: darkmoon2321 on October 09, 2017, 07:45:02 pm
The checksum checking of BPS is a problem for the reason KingMike mentioned - though incidentally my patch deletes the save data, and I hope others making patches will do the same as it's probably appreciated by people who want a nice clean file. How about Xdelta? I've not used it, would it yield a better result in my case? Do you have to manually say where the extra bytes are or can it just figure it out by itself?

I use the utility here as a frontend for xdelta:

https://www.romhacking.net/utilities/704/

You can select whether or not to add a checksum when you create the patch.  As long as you disable the checksum you should be good.  It can figure out where the bytes are by itself.
Title: Re: Zelda 2 FDS Translation
Post by: Psyklax on October 09, 2017, 07:52:34 pm
I use the utility here as a frontend for xdelta:

https://www.romhacking.net/utilities/704/

You can select whether or not to add a checksum when you create the patch.  As long as you disable the checksum you should be good.  It can figure out where the bytes are by itself.

Thanks for the tip, I'll give it a shot. :)
Title: Re: Zelda 2 FDS Translation
Post by: ToHell on October 13, 2017, 04:24:52 pm
hello,

i use fceux-2.2.2-win32 and have found a another bug. then princess zelda awake, her sprite ist broken.


https://picload.org/view/dgiprgri/neuebitmap.png.html
Title: Re: Zelda 2 FDS Translation
Post by: ShadowOne333 on October 13, 2017, 04:53:47 pm
hello,

i use fceux-2.2.2-win32 and have found a another bug. then princess zelda awake, her sprite ist broken.


https://picload.org/view/dgiprgri/neuebitmap.png.html

That one has already been reported iirc:
(https://i.imgur.com/ntbb5YS.png) Finally, some garbage tiles in the game's ending for when Zelda wakes up.
Title: Re: Zelda 2 FDS Translation
Post by: ToHell on November 08, 2017, 01:32:23 pm
I apologize for that, but when is a corrected patch expected?
Title: Re: Zelda 2 FDS Translation
Post by: jackic on January 25, 2019, 11:23:22 am
That one has already been reported iirc:

This patch addresses the Zelda graphics corruption in the ending:

https://mega.nz/#!GSA0hSoB!IuXDsnmTKK0Y_6IEPjqlgOIR2wykw88vNVolmDB6t-E (https://mega.nz/#!GSA0hSoB!IuXDsnmTKK0Y_6IEPjqlgOIR2wykw88vNVolmDB6t-E)

Apply to the ALREADY PATCHED translation 2.33 that is hosted in this very site. I hope it does not broke anything else.
Title: Re: Zelda 2 FDS Translation
Post by: ToHell on February 04, 2019, 10:01:35 pm
The face is lost. I load a savestate.


(https://s15.directupload.net/images/190205/jrflas3d.jpg) (https://www.directupload.net)
Title: Re: Zelda 2 FDS Translation
Post by: KingMike on February 04, 2019, 11:38:55 pm
If you patched the ROM and then loaded a savestate, that might be a problem right there.
Depending on the emulator you use, it might revert the entire contents of the FDS file to what it was at the time of your savestate.
(due to that part of the FDS disk is writable data, emulators might rewrite the whole updated file to disk)

Other emulators might make a copy of the fds file into its save folder and use that copy as its save, while others might make an IPS.
I don't know which way of handling FDS files that particular version of the emulator uses.
Title: Re: Zelda 2 FDS Translation
Post by: jackic on February 05, 2019, 04:25:49 pm
The face is lost. I load a savestate.


(https://s15.directupload.net/images/190205/jrflas3d.jpg) (https://www.directupload.net)

I am fairly positive that it is NOT supposed to have a face until you use the THUNDER spell. Try that!